This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
precompile erc 721 only owner_of #104
precompile erc 721 only owner_of #104
Changes from 58 commits
8a0bc02
0fe9a63
7ebabef
e964668
aba874e
80dd172
9604f6c
390359b
64c449a
5dafd9f
e92faae
21d6842
e06adce
3869690
d514f88
2efff92
0357938
cec3cbf
b0c10ce
1420c21
d0c4ce7
aa84dde
7e49dae
0ec72a7
9be1a5b
2427e0d
4625aad
d858bf0
6c65ddd
1c9e12a
c7ec2ee
c39efbd
9dc0c14
b9bba2d
a39432c
c4cd42f
89af0a0
c6c7810
5cfb2b5
fa612ab
0568c47
b31f1db
9a4f100
09738af
daf2910
bd47de2
907ca7e
10557aa
6d38abe
daef051
f71eef7
15123db
4b0ec80
df59324
2fbd144
96d7374
5bf67b0
2bf2171
9e1bf8d
88e1314
2aa2681
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is really unidiomatic for Rust and Substrate, generally. Either create a trait for all these functions, sth like
LivingAssetsUtils
and implement this trait forPallet
or to some dummy struct and use them to call these functions or just move these functions underimpl<T: Config> Pallet<T> {}
as static functions.they are also missing comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it'll be adressed : #116
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is missing documentation. you can use the comments to leave
TODO
mark for complete implementation ofERC721
as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also forgot to mention that it's not a good practice to use
str
for errors, try to use explicitError
type which you can pass to the trait or type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes totally agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will be addressed here : #116
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sth like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#116