precompile erc 721 only owner_of #104

asiniscalchi · 2023-08-03T15:41:22Z

No description provided.

…nto feature/precompile_erc_721

…piles

tonimateos

Minor comments, plus the View function requirement

pallets/living-assets-ownership/src/functions.rs

precompile/erc721/contracts/IERC721.sol

precompile/erc721/src/lib.rs

precompile/erc721/src/tests.rs

pallets/living-assets-ownership/Cargo.toml

ghost · 2023-08-07T16:10:59Z

pallets/living-assets-ownership/src/lib.rs

+	}
+}
+
+pub fn collection_id_to_address(collection_id: CollectionId) -> H160 {


this is really unidiomatic for Rust and Substrate, generally. Either create a trait for all these functions, sth like LivingAssetsUtils and implement this trait for Pallet or to some dummy struct and use them to call these functions or just move these functions under impl<T: Config> Pallet<T> {} as static functions.

they are also missing comments

it'll be adressed : #116

pallets/living-assets-ownership/src/lib.rs

ghost · 2023-08-07T16:13:06Z

pallets/living-assets-ownership/src/traits.rs

@@ -25,3 +27,7 @@ pub trait CollectionManager<AccountId> {
 	/// Create collection
 	fn create_collection(owner: AccountId) -> Result<CollectionId, &'static str>;
 }
+


documentation

it is missing documentation. you can use the comments to leave TODO mark for complete implementation of ERC721 as well.

pallets/living-assets-ownership/src/tests.rs

runtime/Cargo.toml

ghost · 2023-08-08T11:51:42Z

pallets/living-assets-ownership/src/traits.rs

@@ -25,3 +27,7 @@ pub trait CollectionManager<AccountId> {
 	/// Create collection
 	fn create_collection(owner: AccountId) -> Result<CollectionId, &'static str>;
 }
+


it is missing documentation. you can use the comments to leave TODO mark for complete implementation of ERC721 as well.

ghost · 2023-08-08T11:52:41Z

pallets/living-assets-ownership/src/traits.rs

@@ -25,3 +27,7 @@ pub trait CollectionManager<AccountId> {
 	/// Create collection
 	fn create_collection(owner: AccountId) -> Result<CollectionId, &'static str>;
 }
+
+pub trait Erc721 {
+	fn owner_of(collection_id: CollectionId, asset_id: U256) -> Result<H160, &'static str>;


also forgot to mention that it's not a good practice to use str for errors, try to use explicit Error type which you can pass to the trait or type.

yes totally agree.

it will be addressed here : #116

ghost · 2023-08-08T11:53:04Z

pallets/living-assets-ownership/src/traits.rs

@@ -25,3 +27,7 @@ pub trait CollectionManager<AccountId> {
 	/// Create collection
 	fn create_collection(owner: AccountId) -> Result<CollectionId, &'static str>;
 }
+
+pub trait Erc721 {
+	fn owner_of(collection_id: CollectionId, asset_id: U256) -> Result<H160, &'static str>;


Suggested change

fn owner_of(collection_id: CollectionId, asset_id: U256) -> Result<H160, &'static str>;

type Error;

fn owner_of(collection_id: CollectionId, asset_id: U256) -> Result<H160, &'static str>;

sth like this

precompile/living-assets/src/tests.rs

runtime/Cargo.toml

* Delete polkadot-launch directory * Remove `template` mentions from runtime * Fix clippy * first hello world test * fmt * checking the selectors * testdata updated * renaming * added testdata for owner_of * removed a type declaration * fmt * using macro to help using behavior pattern testing * usign macro * refactoring * refactoring * main tests covered * name refactoring * removed unused dependency * removed testdata * add test on calling unexsiting selector * removed unused code * fix returning errors message * fmt * adding explicit value transferred in tests, and making explicit both methods supported * removing unreachable path * added tests that the implemented methods are non-payable * using closures * refactoring * declare name in temoplate * refactoring PrecompileMock -> Mock * created handle_from_input * added docuemntation * renaming: define_precompile_mock -> define_precompile_mock_simple * renaming: define_precompile_mock_closure -> impl_precompile_mock * name refactoring * refactoring: handle_from_input use create_mock_handle * refactoring: handle_from_input -> create_mock_handle_from_input * comment the inputs * using constants * first try * add create collection returning id to trati * fix compilation * trait crate_collection2 returns Result * test on create collection failure * create collection returns an id * precompiled return from pallet * added create_collection returning id in solidity interface * assign caller as owner * remove legacy create collection in precompile * removed create_collection2 from trait * compiling * compiling * create collection extrinsic create consecutive collections * removed legacy code from solidity interface * create file traits.rs * trait LivingAssetOwnership -> CollectionManager * doc: solidity * documentation * better tests * better testing * fix typo * conversion collection_id to address * removed owner of from precompile * adding test that create_collection is non-payable * checking err is as expected: "non payable" * fixing a test that was failing for a different reason, as shown by testing that the error received was as expected * fix compilation * fix compilation * adding event * added event Create Collection * fmt * copied MockHandle to implement log function * GRANDPA bridge (#106) * Only client side compile errors * Upgrade to v1.0.0 * Add grandpa bridge to runtime * Fix clippy and tests * Fix lints * Fix tests and clippy * Remove comment * test log selector * remove dependency * Mock logs logs * testing event * removed duplicated test * using succeed utility * collection_it_to_addressis private * return value is correctly encoded as a n Address (#109) * return value is correctly encoded as a n Address * removed outdated comment * fix the documentation * precompile erc 721 only owner_of (#104) * create mock and testing * first test * testing ethereum reserved addresses * refactoring * refactoring * refactoring tests * fmt * erc721 starting point * fmt * compiling * check selectors * create trait Erc721 * Erc721Precompile * set mocks * first implermentation * first integration of erc721 in the runtime * fmt * check on the collection id * test on extract owner form asset_id * fix tests * test for erc721 trait * fix compilation * refactoring * returning address * return value is correctly encoded as a n Address * is_erc721_contract is not member of PrecompoileSet * test on precompiled contracts * erc721 returns hardcoded address * refactoring * testing return of asset ownership * fix errors * remove unused use * refactoring * rewriting testing mod * refactoring * moving check for cllection address in pallet * collection address prefix changed * test passing * test passing * refactoring tests * do not panic the runtime * fmt * solidity tokenId -> _tokenId * erc721 functions are views * update docs * sp-core in std , removed duplicate function * documentaetion * using compilator type ifer * compiler infer the size of the array * added to std feature * rename variable * trait documentation * fmt * runtime spec to 4 * fix name on LivingAssetsOwnership pallet (#120) --------- Co-authored-by: dastan <[email protected]> Co-authored-by: Dastan Samatov <[email protected]> Co-authored-by: Toni Mateos <[email protected]>

asiniscalchi added 7 commits August 1, 2023 11:11

create mock and testing

8a0bc02

first test

0fe9a63

testing ethereum reserved addresses

7ebabef

refactoring

e964668

refactoring

aba874e

refactoring tests

80dd172

fmt

9604f6c

asiniscalchi changed the title ~~Feature/precompile erc 721~~ precompile erc 721 Aug 3, 2023

asiniscalchi linked an issue Aug 3, 2023 that may be closed by this pull request

Create collection in Ownchain #88

Closed

asiniscalchi added 2 commits August 3, 2023 18:02

erc721 starting point

390359b

Merge branch 'dev' into feature/precompile_erc_721

64c449a

asiniscalchi changed the title ~~precompile erc 721~~ precompile erc 721 only tockenURI Aug 3, 2023

asiniscalchi added 18 commits August 3, 2023 18:42

fmt

5dafd9f

Merge branch 'dev' into feature/precompile_erc_721

e92faae

Merge branch 'feature/solidity_create_collection_return_an_address' i…

21d6842

…nto feature/precompile_erc_721

compiling

e06adce

check selectors

3869690

create trait Erc721

d514f88

Erc721Precompile

2efff92

set mocks

0357938

first implermentation

cec3cbf

first integration of erc721 in the runtime

b0c10ce

fmt

1420c21

check on the collection id

d0c4ce7

test on extract owner form asset_id

aa84dde

Merge branch 'dev' into feature/precompile_erc_721

7e49dae

fix tests

0ec72a7

test for erc721 trait

9be1a5b

Merge branch 'feature/precompile_erc_721' into feature/testing_precom…

2427e0d

…piles

fix compilation

4625aad

tonimateos suggested changes Aug 7, 2023

View reviewed changes

pallets/living-assets-ownership/src/functions.rs Show resolved Hide resolved

precompile/erc721/contracts/IERC721.sol Outdated Show resolved Hide resolved

precompile/erc721/src/lib.rs Outdated Show resolved Hide resolved

precompile/erc721/src/tests.rs Show resolved Hide resolved

ghost reviewed Aug 7, 2023

View reviewed changes

asiniscalchi added 3 commits August 7, 2023 20:54

refactoring

0568c47

rewriting testing mod

b31f1db

refactoring

9a4f100

asiniscalchi removed a link to an issue Aug 8, 2023

Create collection in Ownchain #88

Closed

asiniscalchi linked an issue Aug 8, 2023 that may be closed by this pull request

OwnerOf asset in a collection #89

Closed

asiniscalchi added 13 commits August 8, 2023 10:26

moving check for cllection address in pallet

09738af

collection address prefix changed

daf2910

test passing

bd47de2

test passing

907ca7e

refactoring tests

10557aa

do not panic the runtime

6d38abe

fmt

daef051

solidity tokenId -> _tokenId

f71eef7

erc721 functions are views

15123db

update docs

4b0ec80

sp-core in std , removed duplicate function

df59324

documentaetion

2fbd144

using compilator type ifer

96d7374

ghost reviewed Aug 8, 2023

View reviewed changes

asiniscalchi added 2 commits August 8, 2023 14:47

compiler infer the size of the array

5bf67b0

added to std feature

2bf2171

tonimateos approved these changes Aug 8, 2023

View reviewed changes

asiniscalchi added 3 commits August 8, 2023 14:03

rename variable

9e1bf8d

trait documentation

88e1314

fmt

2aa2681

asiniscalchi merged commit 6a0b2ce into dev Aug 8, 2023

asiniscalchi deleted the feature/precompile_erc_721 branch August 8, 2023 13:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

precompile erc 721 only owner_of #104

precompile erc 721 only owner_of #104

asiniscalchi commented Aug 3, 2023

tonimateos left a comment

ghost Aug 7, 2023

asiniscalchi Aug 8, 2023

ghost Aug 7, 2023

asiniscalchi Aug 8, 2023

ghost Aug 8, 2023

ghost Aug 8, 2023

ghost Aug 8, 2023

asiniscalchi Aug 8, 2023

asiniscalchi Aug 8, 2023

ghost Aug 8, 2023

ghost Aug 8, 2023

asiniscalchi Aug 8, 2023

	fn owner_of(collection_id: CollectionId, asset_id: U256) -> Result<H160, &'static str>;
	type Error;
	fn owner_of(collection_id: CollectionId, asset_id: U256) -> Result<H160, &'static str>;

precompile erc 721 only owner_of #104

precompile erc 721 only owner_of #104

Conversation

asiniscalchi commented Aug 3, 2023

tonimateos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment