Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better indicator base amount for Tax Witholding in Journal Entry (backport #44660) #44735

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 17, 2024

Support Ticket: https://support.frappe.io/helpdesk/tickets/26923

Use case

Over deduction of TDS from Journal Entry for an expense booked.

Issue

Excess amount reported forms part of income of supplier if reported as is.

Implementation

Base amount for TDS is lower of total JV value or reverse calculation (from tax rate and tax amount being deducted)
This is to based on the assumption that supplier is deducting TDS manually while staying compliant and there is no under deduction.

backport to version-14 and version-15 is expected


This is an automatic backport of pull request #44660 done by Mergify.

@mergify mergify bot requested a review from deepeshgarg007 as a code owner December 17, 2024 06:20
@mergify mergify bot requested a review from ruthra-kumar as a code owner December 17, 2024 06:20
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 17, 2024
@ruthra-kumar
Copy link
Member

@vorasmit vorasmit merged commit 58c0e24 into version-15-hotfix Dec 20, 2024
11 checks passed
@vorasmit vorasmit deleted the mergify/bp/version-15-hotfix/pr-44660 branch December 20, 2024 10:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants