Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better indicator base amount for Tax Witholding in Journal Entry #44660

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

vorasmit
Copy link
Collaborator

@vorasmit vorasmit commented Dec 11, 2024

Support Ticket: https://support.frappe.io/helpdesk/tickets/26923

Use case

Over deduction of TDS from Journal Entry for an expense booked.

Issue

Excess amount reported forms part of income of supplier if reported as is.

Implementation

Base amount for TDS is lower of total JV value or reverse calculation (from tax rate and tax amount being deducted)
This is to based on the assumption that supplier is deducting TDS manually while staying compliant and there is no under deduction.

backport to version-14 and version-15 is expected

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 11, 2024
@vorasmit vorasmit marked this pull request as ready for review December 12, 2024 14:26
@Sunilmehra21
Copy link

Hello @ruthra-kumar
any update on this ???

@ruthra-kumar ruthra-kumar self-assigned this Dec 16, 2024
@ruthra-kumar
Copy link
Member

ruthra-kumar commented Dec 16, 2024

@vorasmit

Is there any way to identify a TDS overbooked scenario, especially through Journal? If so, we can simply report it as overbooked through a new column in the report, rather than approximation.

@vorasmit
Copy link
Collaborator Author

vorasmit commented Dec 16, 2024

How about this approach?

  • User creates a Journal Entry
  • We estimate base tax amount and set it automatically in a field (based on reverse calculation) in Journal Entry
  • User updates this field if he wants

This field than forms basis for the base TDS amount.

@ruthra-kumar
Copy link
Member

ruthra-kumar commented Dec 17, 2024

  • We estimate base tax amount and set it automatically in a field (based on reverse calculation) in Journal Entry

  • User updates this field if he wants

I'm not sure. Adding one more field to Journal Entry further increases complexity and maintenance. Unfortunately, using Journal Entry for everything has lead to this unavoidable ambiguity.

How about a new doctype just for booking TDS? similar to how Landed Cost Voucher works. This allows for separation of concern and better traceability of TDS amounts

@vorasmit
Copy link
Collaborator Author

I'm not sure. Adding one more field to Journal Entry further increases complexity and maintenance. Unfortunately, using Journal Entry for everything has lead to this unavoidable ambiguity.

Agreed

How about a new doctype just for booking TDS? similar to how Landed Cost Voucher works. This allows for separation of concern and better traceability of TDS amounts.

Bigger project. I'll think about it. Until then maybe we keep this fix and take this up as a refactor

@ruthra-kumar ruthra-kumar merged commit 37fb6d1 into frappe:develop Dec 17, 2024
18 checks passed
ruthra-kumar added a commit that referenced this pull request Dec 17, 2024
…-44660

fix: better indicator base amount for Tax Witholding in Journal Entry (backport #44660)
vorasmit added a commit that referenced this pull request Dec 20, 2024
…-44660

fix: better indicator base amount for Tax Witholding in Journal Entry (backport #44660)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants