fix: Issues related to RFQ and Supplier Quotation on Portal #37565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitwaghchaure
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
github-actions
bot
added
accounts
needs-tests
ankush
reviewed
Oct 18, 2023
ankush
added
backport version-13-hotfix
backport version-14-hotfix
mergify bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
fix: RFQ and Supplier Quotation for Portal (cherry picked from commit 2851a41) # Conflicts: # erpnext/accounts/party.py # erpnext/templates/pages/order.html
mergify bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
fix: RFQ and Supplier Quotation for Portal (cherry picked from commit 2851a41)
This was referenced Oct 18, 2023
rohitwaghchaure
added a commit
that referenced
this pull request
Oct 19, 2023
…37565) (#37577) * fix: Issues related to RFQ and Supplier Quotation on Portal (#37565) fix: RFQ and Supplier Quotation for Portal (cherry picked from commit 2851a41) * chore: removed backport changes --------- Co-authored-by: rohitwaghchaure <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Oct 19, 2023
…37565) (#37577) * fix: Issues related to RFQ and Supplier Quotation on Portal (#37565) fix: RFQ and Supplier Quotation for Portal (cherry picked from commit 2851a41) * chore: removed backport changes --------- Co-authored-by: rohitwaghchaure <[email protected]> (cherry picked from commit e1504ef) # Conflicts: # erpnext/templates/includes/rfq.js
rohitwaghchaure
added a commit
that referenced
this pull request
Oct 19, 2023
…37565) (backport #37577) (#37588) * fix: Issues related to RFQ and Supplier Quotation on Portal (backport #37565) (#37577) * fix: Issues related to RFQ and Supplier Quotation on Portal (#37565) fix: RFQ and Supplier Quotation for Portal (cherry picked from commit 2851a41) * chore: removed backport changes --------- Co-authored-by: rohitwaghchaure <[email protected]> (cherry picked from commit e1504ef) # Conflicts: # erpnext/templates/includes/rfq.js * chore: fix conflicts --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: rohitwaghchaure <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
## [13.54.5](v13.54.4...v13.54.5) (2023-10-19) ### Bug Fixes * e-commerce permissions for address (backport [#37554](#37554)) ([#37560](#37560)) ([49d0ab5](49d0ab5)) * **gp:** wrong `allocated_amount` on multi sales person invoice ([7805c3a](7805c3a)) * Issues related to RFQ and Supplier Quotation on Portal (backport [#37565](#37565)) (backport [#37577](#37577)) ([#37588](#37588)) ([bc907b2](bc907b2)) * keep customer/supplier website role by default ([52aff1f](52aff1f)) * negative valuation rate in PR return (backport [#37424](#37424)) ([#37462](#37462)) ([66ad823](66ad823)) * use `flt` to ignore TypeError (backport [#37481](#37481)) ([#37489](#37489)) ([8b4e692](8b4e692))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
## [14.44.1](v14.44.0...v14.44.1) (2023-10-19) ### Bug Fixes * billed_qty to show a sum of all invoiced qty from the purchase order item. (backport [#37539](#37539)) ([#37558](#37558)) ([ac7d6d6](ac7d6d6)) * consider received qty while creating SO -> MR (backport [#37414](#37414)) ([#37514](#37514)) ([1b94510](1b94510)) * don't set finance books if gross_purchase_amount is not set (backport [#37480](#37480)) ([#37482](#37482)) ([0590f21](0590f21)) * e-commerce permissions for address ([#37554](#37554)) ([022f85d](022f85d)) * german tranlations of "Is Return" ([f9b2355](f9b2355)) * GL Entries not getting created for PR Return (backport [#37513](#37513)) ([#37516](#37516)) ([c32258e](c32258e)) * **gp:** wrong `allocated_amount` on multi sales person invoice ([d266423](d266423)) * Incorrect vat amount in KSA VAT report ([44f7de0](44f7de0)) * inflated total amt in TDS report using back calculation ([78e22af](78e22af)) * Issues related to RFQ and Supplier Quotation on Portal (backport [#37565](#37565)) ([#37577](#37577)) ([e1504ef](e1504ef)) * keep customer/supplier website role by default ([76ef61c](76ef61c)) * keyerror on gl and pl comparision report ([6f143d3](6f143d3)) * payment entry count on supplier dashboard (backport [#37571](#37571)) ([#37575](#37575)) ([95abd79](95abd79)) * same Serial No get mapped while creating SO -> DN ([#37527](#37527)) ([5025850](5025850)) * serial and batch no get removed on save of return DN ([#37476](#37476)) ([f1814a1](f1814a1)) * Stock Reconciliation Insufficient Stock Error ([#37494](#37494)) ([9406ddb](9406ddb)) * **test:** project test case (backport [#37541](#37541)) ([#37543](#37543)) ([e23710b](e23710b)) * use `flt` to ignore TypeError ([#37481](#37481)) ([d2b22db](d2b22db)) ### Performance Improvements * index `dn_detail` in `Delivery Note Item` (backport [#37528](#37528)) ([#37530](#37530)) ([001c230](001c230))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Incomplete processing of supplier quotations upon submit by the supplier from the supplier portal #37531
After Fixed
After fix