Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: e-commerce permissions for address #37554

Merged
merged 2 commits into from
Oct 18, 2023
Merged

fix: e-commerce permissions for address #37554

merged 2 commits into from
Oct 18, 2023

Conversation

ankush
Copy link
Member

@ankush ankush commented Oct 17, 2023 •
edited
Loading

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. selling labels Oct 17, 2023
@ankush ankush added backport version-14-hotfix backport to version 14 backport version-13-hotfix and removed needs-tests This PR needs automated unit-tests. labels Oct 17, 2023
@ankush ankush merged commit 1d186ef into develop Oct 18, 2023
11 of 12 checks passed
@ankush ankush deleted the e_com_perms branch October 18, 2023 05:38
This was referenced Oct 18, 2023
Merged
Merged
deepeshgarg007 pushed a commit that referenced this pull request Oct 18, 2023
@mergify @ankush
fix: e-commerce permissions for address (#37554)
022f85d 
* fix: E-commerce permissions

(cherry picked from commit f4d7499)

# Conflicts:
#	erpnext/controllers/selling_controller.py

* chore: conflicts

---------

Co-authored-by: Ankush Menat <[email protected]>
ankush added a commit that referenced this pull request Oct 18, 2023
@mergify @ankush
fix: e-commerce permissions for address (backport #37554) (#37560)
49d0ab5 
* fix: E-commerce permissions

(cherry picked from commit f4d7499)

# Conflicts:
#	erpnext/accounts/party.py
#	erpnext/controllers/selling_controller.py

* chore: conflicts

---------

Co-authored-by: Ankush Menat <[email protected]>
frappe-pr-bot pushed a commit that referenced this pull request Oct 19, 2023
@frappe-bot
chore(release): Bumped to Version 13.54.5
2410355 
## [13.54.5](v13.54.4...v13.54.5) (2023-10-19)

### Bug Fixes

* e-commerce permissions for address (backport [#37554](#37554)) ([#37560](#37560)) ([49d0ab5](49d0ab5))
* **gp:** wrong `allocated_amount` on multi sales person invoice ([7805c3a](7805c3a))
* Issues related to RFQ and Supplier Quotation on Portal (backport [#37565](#37565)) (backport [#37577](#37577)) ([#37588](#37588)) ([bc907b2](bc907b2))
* keep customer/supplier website role by default ([52aff1f](52aff1f))
* negative valuation rate in PR return (backport [#37424](#37424)) ([#37462](#37462)) ([66ad823](66ad823))
* use `flt` to ignore TypeError (backport [#37481](#37481)) ([#37489](#37489)) ([8b4e692](8b4e692))
frappe-pr-bot pushed a commit that referenced this pull request Oct 19, 2023
@frappe-bot
chore(release): Bumped to Version 14.44.1
6931db9 
## [14.44.1](v14.44.0...v14.44.1) (2023-10-19)

### Bug Fixes

* billed_qty to show a sum of all invoiced qty from the purchase order item. (backport [#37539](#37539)) ([#37558](#37558)) ([ac7d6d6](ac7d6d6))
* consider received qty while creating SO -> MR (backport [#37414](#37414)) ([#37514](#37514)) ([1b94510](1b94510))
* don't set finance books if gross_purchase_amount is not set (backport [#37480](#37480)) ([#37482](#37482)) ([0590f21](0590f21))
* e-commerce permissions for address ([#37554](#37554)) ([022f85d](022f85d))
* german tranlations of "Is Return" ([f9b2355](f9b2355))
* GL Entries not getting created for PR Return (backport [#37513](#37513)) ([#37516](#37516)) ([c32258e](c32258e))
* **gp:** wrong `allocated_amount` on multi sales person invoice ([d266423](d266423))
* Incorrect vat amount in KSA VAT report ([44f7de0](44f7de0))
* inflated total amt in TDS report using back calculation ([78e22af](78e22af))
* Issues related to RFQ and Supplier Quotation on Portal (backport [#37565](#37565)) ([#37577](#37577)) ([e1504ef](e1504ef))
* keep customer/supplier website role by default ([76ef61c](76ef61c))
* keyerror on gl and pl comparision report ([6f143d3](6f143d3))
* payment entry count on supplier dashboard (backport [#37571](#37571)) ([#37575](#37575)) ([95abd79](95abd79))
* same Serial No get mapped while creating SO -> DN ([#37527](#37527)) ([5025850](5025850))
* serial and batch no get removed on save of return DN ([#37476](#37476)) ([f1814a1](f1814a1))
* Stock Reconciliation Insufficient Stock Error ([#37494](#37494)) ([9406ddb](9406ddb))
* **test:** project test case (backport [#37541](#37541)) ([#37543](#37543)) ([e23710b](e23710b))
* use `flt` to ignore TypeError ([#37481](#37481)) ([d2b22db](d2b22db))

### Performance Improvements

* index `dn_detail` in `Delivery Note Item` (backport [#37528](#37528)) ([#37530](#37530)) ([001c230](001c230))
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@vishakhdesai vishakhdesai mentioned this pull request Nov 18, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees
No one assigned
Labels
accounts backport version-13-hotfix backport version-14-hotfix backport to version 14 selling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cutsomer Permission Error on login when using Shopping Cart
1 participant
@ankush