fix: error when there is no billing address in shopify order

ecommerce_integrations/shopify/order.py

@@ -38,9 +38,9 @@
 		create_shopify_log(status="Invalid", message="Sales order already exists, not synced")
 		return
 	try:
 		shopify_customer = order.get("customer") if order.get("customer") is not None else {}
 		shopify_customer["billing_address"] = order.get("billing_address", "")
 		shopify_customer["shipping_address"] = order.get("shipping_address", "")
 		customer_id = shopify_customer.get("id")
 		if customer_id:
 			customer = ShopifyCustomer(customer_id=customer_id)
@@ -74,9 +74,9 @@
 
 
 def create_sales_order(shopify_order, setting, company=None):
 	customer = setting.default_customer
-	if customer_id := shopify_order.get("customer", {}).get("id"):
+	if customer_id := shopify_order.get("customer").get("id") if shopify_order.get("customer") is not None else "":
 		customer = frappe.db.get_value("Customer", {CUSTOMER_ID_FIELD: customer_id}, "name")
 
 	so = frappe.db.get_value("Sales Order", {ORDER_ID_FIELD: shopify_order.get("id")}, "name")
 
@@ -100,7 +100,7 @@
 
 			return ""
 
 		taxes = get_order_taxes(shopify_order, setting, items)
 		so = frappe.get_doc(
 			{
 				"doctype": "Sales Order",
@@ -215,7 +215,7 @@
 				}
 			)
 
 	update_taxes_with_shipping_lines(
 		taxes,
 		shopify_order.get("shipping_lines"),
 		setting,
@@ -223,22 +223,22 @@
 		taxes_inclusive=shopify_order.get("taxes_included"),
 	)
 
 	if cint(setting.consolidate_taxes):
 		taxes = consolidate_order_taxes(taxes)
 
 	for row in taxes:
 		tax_detail = row.get("item_wise_tax_detail")
 		if isinstance(tax_detail, dict):
 			row["item_wise_tax_detail"] = json.dumps(tax_detail)
 
 	return taxes
 
 
 def consolidate_order_taxes(taxes):
 	tax_account_wise_data = {}
 	for tax in taxes:
 		account_head = tax["account_head"]
 		tax_account_wise_data.setdefault(
 			account_head,
 			{
 				"charge_type": "Actual",
@@ -251,11 +251,11 @@
 				"item_wise_tax_detail": {},
 			},
 		)
 		tax_account_wise_data[account_head]["tax_amount"] += flt(tax.get("tax_amount"))
 		if tax.get("item_wise_tax_detail"):
 			tax_account_wise_data[account_head]["item_wise_tax_detail"].update(tax["item_wise_tax_detail"])
 
 	return tax_account_wise_data.values()
 
 
 def get_tax_account_head(tax, charge_type: Optional[Literal["shipping", "sales_tax"]] = None):
@@ -265,8 +265,8 @@
 		"Shopify Tax Account", {"parent": SETTING_DOCTYPE, "shopify_tax": tax_title}, "tax_account",
 	)
 
 	if not tax_account and charge_type:
 		tax_account = frappe.db.get_single_value(SETTING_DOCTYPE, DEFAULT_TAX_FIELDS[charge_type])
 
 	if not tax_account:
 		frappe.throw(_("Tax Account not specified for Shopify Tax {0}").format(tax.get("title")))
@@ -287,7 +287,7 @@
 def update_taxes_with_shipping_lines(taxes, shipping_lines, setting, items, taxes_inclusive=False):
 	"""Shipping lines represents the shipping details,
 	each such shipping detail consists of a list of tax_lines"""
 	shipping_as_item = cint(setting.add_shipping_as_item) and setting.shipping_item
 	for shipping_charge in shipping_lines:
 		if shipping_charge.get("price"):
 			shipping_discounts = shipping_charge.get("discount_allocations") or []
@@ -300,8 +300,8 @@
 			if bool(taxes_inclusive):
 				shipping_charge_amount -= total_tax
 
 			if shipping_as_item:
 				items.append(
 					{
 						"item_code": setting.shipping_item,
 						"rate": shipping_charge_amount,
@@ -312,7 +312,7 @@
 					}
 				)
 			else:
 				taxes.append(
 					{
 						"charge_type": "Actual",
 						"account_head": get_tax_account_head(shipping_charge, charge_type="shipping"),
@@ -395,21 +395,21 @@
 
 @temp_shopify_session
 def sync_old_orders():
 	shopify_setting = frappe.get_cached_doc(SETTING_DOCTYPE)
 	if not cint(shopify_setting.sync_old_orders):
 		return
 
 	orders = _fetch_old_orders(shopify_setting.old_orders_from, shopify_setting.old_orders_to)
 
 	for order in orders:
 		log = create_shopify_log(
 			method=EVENT_MAPPER["orders/create"], request_data=json.dumps(order), make_new=True
 		)
 		sync_sales_order(order, request_id=log.name)
 
 	shopify_setting = frappe.get_doc(SETTING_DOCTYPE)
 	shopify_setting.sync_old_orders = 0
 	shopify_setting.save()
 
 
 def _fetch_old_orders(from_time, to_time):