Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error when there is no billing address in shopify order #284

Closed
wants to merge 1 commit into from

Conversation

saadsafda
Copy link
Contributor

fix: error when there is no billing address in shopify order

@saadsafda saadsafda requested a review from ankush as a code owner November 20, 2023 12:16
@mubi64
Copy link

mubi64 commented Nov 20, 2023

fixes #280

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 275 lines in your changes are missing coverage. Please review.

Comparison is base (1cbdf6b) 40.95% compared to head (6412ce0) 39.58%.
Report is 165 commits behind head on main.

Files Patch % Lines
...octype/amazon_sp_api_settings/amazon_repository.py 68.20% 55 Missing ⚠️
ecommerce_integrations/unicommerce/pick_list.py 0.00% 51 Missing ⚠️
...e/amazon_sp_api_settings/amazon_sp_api_settings.py 14.58% 41 Missing ⚠️
ecommerce_integrations/shopify/order.py 14.28% 36 Missing ⚠️
...commerce_integrations/unicommerce/delivery_note.py 46.93% 26 Missing ⚠️
ecommerce_integrations/unicommerce/invoice.py 23.07% 20 Missing ⚠️
ecommerce_integrations/shopify/inventory.py 0.00% 18 Missing ⚠️
ecommerce_integrations/unicommerce/order.py 44.44% 5 Missing ⚠️
.../zenoti/doctype/zenoti_settings/zenoti_settings.py 0.00% 4 Missing ⚠️
...zon/doctype/amazon_fields_map/amazon_fields_map.py 0.00% 3 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
- Coverage   40.95%   39.58%   -1.37%     
==========================================
  Files          62       68       +6     
  Lines        4244     4406     +162     
==========================================
+ Hits         1738     1744       +6     
- Misses       2506     2662     +156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ankush ankush changed the base branch from main to develop November 20, 2023 15:32
@ankush ankush changed the base branch from develop to main November 20, 2023 15:32
@ankush
Copy link
Member

ankush commented Nov 23, 2023

Can you please send PR to develop, I can't merge things to main directly.

@ankush ankush closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants