Removes depricated --inorder xacro argument #139
Conversation
|
@reviewers I don't think the build error was caused by the changes I made. It might be solved by rerunning the checks. |
rickstaa
force-pushed
the
remove-inorder-argument
branch
from
a33a78b to
31d750a
Compare
|
@frankaemika I rebased this pull request onto the upstream/noetic-devel branch such that all the conflicts are gone. I now think now it can be safely merged. |
rickstaa
force-pushed
the
remove-inorder-argument
branch
2 times, most recently
from
0e238b3 to
61de887
Compare
|
No I don't think the Travis build was due to your commit. We dropped the Travis CI now in favor of Github actions. Could you again please rebase on our latest Regarding the change itself, I think we should be good to merge this. AFAIK we kept this flag in to support Kinetic, but since it's officially outdated since April it makes sense to get rid of the warning. |
rickstaa
force-pushed
the
remove-inorder-argument
branch
3 times, most recently
from
55cf080 to
17be895
Compare
|
@gollth Ah that makes sense! I haven't used kinetic in a long time, so I forgot about that. I rebased the pull request if you still want to merge it. |
|
We dropped further merges into the Kinetic branch and disabled the CI for that. Can you rebase on |
This commit removes the --inorder argument from any xacro commands. This was done to remove the --inorder deprication warning.
rickstaa
force-pushed
the
remove-inorder-argument
branch
from
17be895 to
659a728
Compare
This commit removes the --inorder argument from any
xacrocommands. This was done to remove the--inorderdeprecation warning.