Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with ps format options #110

Merged
merged 2 commits into from
Jul 4, 2021

Conversation

SamuelSarle
Copy link
Contributor

#105 introduced a call to ps -o exe= but exe isn't a standard option and not found in some versions of ps.

Changing exe to command fixes this issue. The command option is found in Linux, MacOS, FreeBSD, OpenBSD man pages for ps and should therefore be available.

Tested on NixOS

Fixes #109

@avant1
Copy link

avant1 commented Jun 23, 2021

This patch fixes aforementioned issue for my environment:

fish, version 3.2.2
tmux 3.0a
Pop!_OS 20.04 LTS

@jaideeprana
Copy link

Hi,

Any ETA on when this PR can be merged?

@AaronLasseigne
Copy link
Contributor

This fixed it for me.

fish 3.3.0
tmux 3.2a
macOS 11.4 

@jaideeprana
Copy link

@AaronLasseigne Since it's working when can this be merged to the master?

@franciscolourenco
Copy link
Owner

Hey everyone, sorry for the delay on merging this PR.

@SamuelSarle would it make sense to call string match directly instead of using a pipe like in https://github.com/franciscolourenco/done/pull/111/files#diff-3e8fa8c31a036bc177a78e46da54de1c74b7da15ce98914fddfba37c1f444d48R114

@SamuelSarle
Copy link
Contributor Author

@franciscolourenco Yes, it would be better. Pushed a commit.

@franciscolourenco franciscolourenco merged commit 3524fdb into franciscolourenco:master Jul 4, 2021
@franciscolourenco
Copy link
Owner

Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Did not work on Mac OS (11.4): ps: unsupported exe keyword
5 participants