Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle nested shell in tmux #105

Merged
merged 1 commit into from
May 19, 2021
Merged

handle nested shell in tmux #105

merged 1 commit into from
May 19, 2021

Conversation

peng1999
Copy link
Contributor

Currently the script does not work in nested shells in tmux. This change repeatedly find the parent process id until the parent is tmux.

@franciscolourenco
Copy link
Owner

@peng1999 Thank you for the contribution. I've merged a new PR and now there are some conflicts. Would you mind addressing those before I merge? Thanks!

@peng1999
Copy link
Contributor Author

@franciscolourenco PR is updated.
This PR completely overrides the changes of #107, but It handles more situation (nested fish process) and should works across fish versions.

@franciscolourenco
Copy link
Owner

@peng1999 Thank you for the contribution

@franciscolourenco franciscolourenco merged commit 667d91e into franciscolourenco:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants