#135 Print page path on error #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fralau
reviewed
May 14, 2022
| from mkdocs.structure.pages import Page | ||
|
|
||
|
|
||
| @singledispatch |
There was a problem hiding this comment.
Creating an ad-hoc function was a good idea. 👍
| @@ -685,7 +671,10 @@ def on_page_markdown(self, markdown, page, config, | |||
| for func in self.pre_macro_functions: | |||
| func(self) | |||
| # render the macros | |||
| self._raw_markdown = self.render(markdown) | |||
| self._raw_markdown = self.render( | |||
There was a problem hiding this comment.
So you added the page argument, for debugging purposes?
There was a problem hiding this comment.
Yes, that is necessary to print the excerpt of the page content in the error handler function.
| ).strip() % traceback.format_exc() | ||
|
|
||
|
|
||
| @format_error.register |
There was a problem hiding this comment.
Shouldn't it be @format_error.register(TemplateSyntaxError) ?
There was a problem hiding this comment.
Not necessarily. As per functools.singledispatch docs,
For functions annotated with types, the decorator will infer the type of the first argument automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on_error_failparameter in the config file (issue Add an option to raise exception if render fails #133)