-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indicate the page where rendering failed #135
Comments
Welcome to this project and thank you!' first issue |
Yes it makes sense. For the record, could you provide an example of the error message you are getting (without the filename)? |
@fralau yes:
This is an error raised by my own code (a macro that I am calling). I am preparing a PR right now. |
After the change:
|
The PR: #136 |
@anatoly-scherbakov Thanks for PR #136. My first impression is that it is a darn good job; let me check it in detail. |
I have spotted some issues there, pushed new commits :) |
I greatly appreciate #133 which helps to be certain that the site builds correctly, and to prevent errors from sneaking into production. There is one little caveat though: if, while rendering, the process fails it might be hard to understand on which page the failure happened.
I propose to print the page path in the error message.
The text was updated successfully, but these errors were encountered: