Fix Video Creation #25
Conversation
Creating objects as a side effect of importing a module creates a new object each time and can lead to unexpected behaviour. Remove attempted workaround.
Simplify the layout using Gtk.Paned and reduce the number of Gtk.Boxes. Allows user to expand the settings.
Fix strange behaviour from partially initialised dialogs by replacing global management code with straightforward use of objects.
PainterDialog needs to be non-modal to allow the user to click on the fractal.
BrowserDialog objects are parentless to allow the user to reposition away from the fractal and see applied changes. Current formula and file are selected when the dialog is opened. A new dialog is created on each use. Converting to an object level dialog that is hidden between uses would require a review of the dialog and browser_model.
Ensure they remain fully in scope after adding to the MainWindow toolbar.
This reverts commit a89e39c. A workaround no longer needed now that fourway is a widget.
Options passed to transcode no longer work. transcode has not been updated for years, has been removed from Debian, and uses ffmpeg itself.
If the file chooser dialog is opened start with the entered file.
Simplify layout using a GtkButtonBox.
|
Video uses VP9, mention that in docs and commit message. |
All values were being set to zero.
Specifying the video codec seems necesary to produce a quality output. Use open WebM format with VP9 encoding Also: - captures output status from ffmpeg - kills ffmpeg when user quits
Avoid user having to enter all the details again.
|
Sorry for delay, I have been out of town. I have added you to the collaborators list, please feel free to make any changes to python3 branch. Hopefully we can merge that back to master fairly soon... |
|
No hurry. I've got another batch on the go - I think that will then be it for the minimum needed to switch over to Python 3 - assuming the selection box performance is acceptable now. Even a few minor improvements included!. Just need a bit more time to tidy it up. Thanks for the invite. |
|
I've pushed to the python3 branch. That is all I have (except something on the icons which I will post on that issue) - which is just as well because it is quite a lot. N.B. to review especially: I have removed unused code from both fract4d and frac4dgui, saving what looked like it was stand-alone to fractutils. Also removed fractutils from installation in setup.py, some of it still needs conversion and I think at least the executables need to go somewhere other than site-packages. I'll summarise some of the more interesting items to try and make it a bit easier to digest: User visible Additions: Main window size is saved on exit and restored on startup Changes: Don't install fractutils. Conversion to Python 3 is not complete and installing executables in site-packages is not very convenient. Fixes: Save as hi-res was overwriting Save as current dialog Developer Changes: Rewrite comand-line options with argparse Fixes: |
Fix Video Creation
Fix Video Creation
Fix Video Creation
Fix Video Creation
Fix Video Creation
Fix Video Creation
Fix Video Creation
Fix Video Creation
Fix Video Creation
Fix Video Creation
This is on top of #24.
Hopefully fixes #7, transcode option
--use_rgbis not supported in 1.1.7 and problems with the image list too. As latest transcode is I believe 7 years old and looks like it won't work with ImageMagick 7 I've changed the code to use ffmpeg direct. The video is set to webm format.I removed the threading and used GLib.spawn_async instead. As well as simplifying the code a plus is that it can now detect success/failure and the user can cancel generation. I haven't implemented progress reporting though.
Added the ability to type the video filename straight into the Directory dialog.
Fixed a bug in that all the settings in the Director dialog were set to 0 on opening.
Usual tidy up and fix as many deprecation warnings as possible.
This does generate video but worth checking it is as expected.
The ffmpeg file list format can support durations for each listed frame so some savings may be possible by using that.