Dialog Objects #24
Merged
Dialog Objects #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating objects as a side effect of importing a module creates a new object each time and can lead to unexpected behaviour. Remove attempted workaround.
Simplify the layout using Gtk.Paned and reduce the number of Gtk.Boxes. Allows user to expand the settings.
Fix strange behaviour from partially initialised dialogs by replacing global management code with straightforward use of objects.
PainterDialog needs to be non-modal to allow the user to click on the fractal.
BrowserDialog objects are parentless to allow the user to reposition away from the fractal and see applied changes. Current formula and file are selected when the dialog is opened. A new dialog is created on each use. Converting to an object level dialog that is hidden between uses would require a review of the dialog and browser_model.
Ensure they remain fully in scope after adding to the MainWindow toolbar.
This reverts commit a89e39c. A workaround no longer needed now that fourway is a widget.
|
Rebased to remove this workaround: |
Merged
da2ce7
pushed a commit
to da2ce7/fract4d-gnofract4d
that referenced
this pull request
Feb 17, 2020
Dialog Objects
da2ce7
pushed a commit
to da2ce7/fract4d-gnofract4d
that referenced
this pull request
Feb 17, 2020
Dialog Objects
da2ce7
pushed a commit
to da2ce7/fract4d-gnofract4d
that referenced
this pull request
Feb 17, 2020
Dialog Objects
da2ce7
pushed a commit
to da2ce7/fract4d-gnofract4d
that referenced
this pull request
Feb 20, 2020
Dialog Objects
da2ce7
pushed a commit
to da2ce7/fract4d-gnofract4d
that referenced
this pull request
Apr 9, 2020
Dialog Objects
da2ce7
pushed a commit
to da2ce7/fract4d-gnofract4d
that referenced
this pull request
Apr 9, 2020
Dialog Objects
da2ce7
pushed a commit
to da2ce7/fract4d-gnofract4d
that referenced
this pull request
Apr 9, 2020
Dialog Objects
da2ce7
pushed a commit
to da2ce7/fract4d-gnofract4d
that referenced
this pull request
Apr 20, 2020
Dialog Objects
da2ce7
pushed a commit
to da2ce7/fract4d-gnofract4d
that referenced
this pull request
Apr 20, 2020
Dialog Objects
da2ce7
pushed a commit
to da2ce7/fract4d-gnofract4d
that referenced
this pull request
Apr 20, 2020
Dialog Objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd seen various bits of odd behaviour, first with the fourway's leading to a89e39c.
Also GTK+ Critical errors on the command line and Python exceptions.
And something strange in the code:
https://github.com/edyoung/gnofract4d/blob/572dbeecde9cef266167a479368675c710e77926/fract4dgui/browser.py#L162-L163
I can't find any other examples of testing the existence of GtkTreeSelection, indeed the GTK+ docs say:
"The GtkTreeSelection object is automatically created when a new GtkTreeView widget is created, and cannot exist independently of this widget."
I think this is all the result of a confusion of classes, objects, static methods and scope. This set attempts to fix that.
There are a couple of improvements too:
Hope that makes sense. There a few comments in the commit messages.