Use Python 3.8 for CI builds #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achim-k
force-pushed
the
achim/pipfile-pyton-3.7
branch
from
c69b5a6 to
407409f
Compare
achim-k
force-pushed
the
achim/pipfile-pyton-3.7
branch
from
3806667 to
c5c9c52
Compare
achim-k
changed the title
jtbandes
approved these changes
Oct 5, 2023
I initially tried with 3.7 but that resulted in various errors due to a deprecated endpoint. (the library mentioned in that answer also requires Python 3.8 now)
Good question, I'll see if I can find out why these errors (there are more after fixing that one) suddenly appear |
pezy
pushed a commit
to pezy/mcap
that referenced
this pull request
Jan 11, 2024
### Public-Facing Changes
Use Python 3.8 for CI builds
### Description
Ensures that Python3.8 is used for CI. This was not the case so far as
`pipenv` was "resetting" the python version:
```
make lint
shell: /usr/bin/bash -e {0}
env:
pythonLocation: /opt/hostedtoolcache/Python/3.7.17/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.7.17/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.7.17/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.7.17/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.7.17/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.7.17/x64/lib
SETUPTOOLS_ENABLE_FEATURES="legacy-editable" pipenv install --dev --deploy
Creating a virtualenv for this project...
Pipfile: /home/runner/work/mcap/mcap/python/Pipfile
Using /usr/bin/python3 (3.10.12) to create virtualenv...
created virtual environment CPython3.10.12.final.0-64 in 636ms
```
jtbandes
added a commit
that referenced
this pull request
Dec 12, 2024
### Changelog None ### Docs None ### Description CI [broke recently](https://github.com/foxglove/mcap/actions/runs/12302494967) because (I think) `ubuntu-latest` changed to `ubuntu-24.04`. The 24.04 image no longer has python 3.7/3.8 (actions/runner-images#10636). It also causes an error with the `setup-swift` action (swift-actions/setup-swift#677). ~Our `setup.cfg` declares `python_requires = >=3.7`, however we were using 3.8 in most CI jobs (#988). I downgraded these from 3.8 to 3.7 here.~ It was hard to get this working so I left it at 3.8. - Included a drive-by lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Use Python 3.8 for CI builds
Description
Ensures that Python3.8 is used for CI. This was not the case so far as
pipenvwas "resetting" the python version:Resolves FG-5220