Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use individual fork to submit homebrew updates #1064

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

amacneil
Copy link
Contributor

Public-Facing Changes

None

Description

Use @foxglovebot's "personal" fork of homebrew to release CLI versions, rather than the @foxglove org's fork. This allows homebrew automation to amend the PR.

Fixes #1063

@amacneil amacneil changed the title Use personal fork to submit homebrew updates Use individual fork to submit homebrew updates Feb 14, 2024
Copy link
Collaborator

@james-rms james-rms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep the commit message?

@amacneil
Copy link
Contributor Author

Why not keep the commit message?

The first two lines of the commit message are the default.

The third line of the commit message was not actually @mentioning us (see Homebrew/homebrew-core#162640 for example).

@amacneil amacneil merged commit 5445c54 into main Feb 14, 2024
25 checks passed
@amacneil amacneil deleted the adrian/mcap-brew-fork branch February 14, 2024 03:29
@jtbandes
Copy link
Member

The dream of @ mentions has died. I tried many things and was unable to get it to work.

@jtbandes
Copy link
Member

Turns out this also broke the action completely because https://github.com/mislav/bump-homebrew-formula-action/tree/5a3f2e95b18e8647880bffc858ab1a71da42af4c does not have a lib folder (build products)` in it, while https://github.com/mislav/bump-homebrew-formula-action/tree/b3327118b2153c82da63fd9cbf58942146ee99f0 did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Request from Homebrew maintainers
3 participants