Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request from Homebrew maintainers #1063

Closed
p-linnane opened this issue Feb 14, 2024 · 7 comments · Fixed by #1064
Closed

Request from Homebrew maintainers #1063

p-linnane opened this issue Feb 14, 2024 · 7 comments · Fixed by #1064
Labels
bug Something isn't working

Comments

@p-linnane
Copy link

Hello 👋 . I'm a maintainer for the Homebrew project. I'm reaching out regarding the automated version bump PR's for mcap. As part of our merge process, we push our built bottles to the PR branch. Since your automated PR's are being opened from an org fork, we are unable to push to it. This requires us to recreate a new PR to get the bottles merged. I'd like to request that you open future automated PR's from a non-org fork to simplify the merge process for us. Thanks!
@p-linnane p-linnane added the bug Something isn't working label Feb 14, 2024
This was referenced Feb 14, 2024
Merged
Merged
@amacneil
Copy link
Contributor

amacneil commented Feb 14, 2024 •
edited
Loading

Hey, thanks for flagging. I think #1064 will fix this.

I also submitted a readme update mislav/bump-homebrew-formula-action#150 to mislav/bump-homebrew-formula-action which will hopefully reduce the number of others who fall into the same trap.

amacneil added a commit that referenced this issue Feb 14, 2024
@amacneil
Use individual fork to submit homebrew updates (#1064)
5445c54 
### Public-Facing Changes
None

### Description
Use @foxglovebot's "personal" fork of homebrew to release CLI versions,
rather than the @foxglove org's fork. This allows homebrew automation to
amend the PR.

Fixes #1063
@amacneil
Copy link
Contributor

We won't know for sure if this worked until we do a new release, but I can keep an eye on it.

@jtbandes
Copy link
Member

It turns out that our automatic PRs have been broken for a while (since #1064). However, it looks like @chenrui333 occasionally updates the formula automatically: Homebrew/homebrew-core#168179

@p-linnane @chenrui333 Is this something we can rely on, or should we pursue a fix for our automatic PRs?

@p-linnane
Copy link
Author

mcap has been added to our autobump list, which means we automatically check for new releases every few hours and automatically open a PR if one is found. You shouldn't need to worry about opening PR's.

@jtbandes
Copy link
Member

Great, thank you!

@jtbandes
Copy link
Member

Is there any way the maintainers of this project can be notified if a future bump fails to build? Will the homebrew maintainers open an issue here?

@p-linnane
Copy link
Author

We will try to fix the build, and if we can't then we would open an issue here.

@jtbandes jtbandes mentioned this issue Apr 24, 2024
Merged
defunctzombie pushed a commit that referenced this issue Apr 25, 2024
@jtbandes
Remove update-homebrew-formula CI job (#1163)
aa4c645 
This job is broken, and is no longer necessary since mcap will be
auto-bumped by the homebrew infrastructure:
#1063 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use individual fork to submit homebrew updates foxglove/mcap
3 participants
@jtbandes @amacneil @p-linnane