Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cast send,call, estimate print revert reason(data) #8607

Closed
wants to merge 1 commit into from

Conversation

cuiweixie
Copy link
Contributor

@cuiweixie cuiweixie commented Aug 5, 2024

Motivation

Solution

closes #8606 closes #8603

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions

wdyt @klkvr ?

crates/cast/bin/tx.rs Outdated Show resolved Hide resolved
crates/cast/bin/tx.rs Outdated Show resolved Hide resolved
@cuiweixie cuiweixie requested a review from mattsse August 6, 2024 00:36
@cuiweixie cuiweixie changed the title feat: cast send print revert reason(data) feat: cast send,call, estimate print revert reason(data) Aug 6, 2024
@cuiweixie
Copy link
Contributor Author

cuiweixie commented Aug 6, 2024

@mattsse I am not sure if my use of git push -f has overridden your request for changes. If it did, I am very sorry; that was not my intention. I did not notice your actions when I used git push -f.

@klkvr
Copy link
Member

klkvr commented Aug 6, 2024

I am wondering if this should be updated in alloy instead?

In ethers all fields of error payload were formatted:
https://github.com/gakonst/ethers-rs/blob/34ed9e372e66235aed7074bc3f5c14922b139242/ethers-providers/src/rpc/transports/common.rs#L73

vs in alloy:
https://github.com/alloy-rs/alloy/blob/68c8bfc2b786e6e460475b28e0f2453bbcf90e55/crates/json-rpc/src/response/error.rs#L86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants