Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(cast): revert reason is not printed upon failed execution #8603

Closed
cuiweixie opened this issue Aug 5, 2024 · 3 comments
Closed

bug(cast): revert reason is not printed upon failed execution #8603

cuiweixie opened this issue Aug 5, 2024 · 3 comments
Labels
C-cast Command: cast P-normal Priority: normal T-bug Type: bug T-to-reproduce Type: requires reproduction
Milestone

Comments

@cuiweixie
Copy link
Contributor

cuiweixie commented Aug 5, 2024

Component

Cast

Describe the feature you would like

➜  foundry_test git:(master) ✗ cast send 0x5FbDB2315678afecb367f032d93F642f64180aa3  "customError()" --private-key $PK
Error:
server returned an error response: error code 3: execution reverted:

cast send result in execution revert with out reason(data) is hard to debug.

old version of cast send result would be like:

(code: 3, message: execution reverted: CustomError3333, data: Some(String("0x8d6ea8be0000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000000f437573746f6d4572726f72333333330000000000000000000000000000000000"))) 

it's good to make cast send print data like "0x8d6ea8be...".

Additional context

it's good to make cast send print data like "0x8d6ea8be...".

@cuiweixie cuiweixie added the T-feature Type: feature label Aug 5, 2024
@zerosnacks zerosnacks added T-bug Type: bug and removed T-feature Type: feature labels Aug 6, 2024
@zerosnacks zerosnacks changed the title cast send print revert reason when failed. bug(cast): revert reason is not printed upon failed execution Aug 6, 2024
@zerosnacks zerosnacks added the C-cast Command: cast label Aug 6, 2024
@zerosnacks zerosnacks added this to the v1.0.0 milestone Aug 6, 2024
@grandizzy grandizzy added T-to-reproduce Type: requires reproduction P-normal Priority: normal labels Nov 14, 2024
@grandizzy
Copy link
Collaborator

no longer the case, the err is not truncated anymore and displaying

Error: server returned an error response: error code 3: execution reverted: custom error 0x7a0e1985: ed, data: "0x7a0e198500000000000000000000000000000000000000000000000000000000000000650000000000000000000000000000000000000000000000000000000000000064"

please reopen if still issues. thank you!

@grandizzy grandizzy closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2024
@umbertov
Copy link

@grandizzy seems like it's time to reopen the issue? Just got hit with

Error: Failed to send transaction

Context:
- Error #0: Failed to estimate gas for tx
- Error #1: server returned an error response: error code 3: execution reverted

I've been scratching my head about why the execution reverted, and found this issue.

@grandizzy
Copy link
Collaborator

grandizzy commented Nov 27, 2024

@grandizzy seems like it's time to reopen the issue? Just got hit with

Error: Failed to send transaction

Context:
- Error #0: Failed to estimate gas for tx
- Error #1: server returned an error response: error code 3: execution reverted

I've been scratching my head about why the execution reverted, and found this issue.

That's different, the original issue was that execution reverted with custom error and error msg truncated. In your case looks like gas estimation, see first line, maybe you need to tweak your command?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cast Command: cast P-normal Priority: normal T-bug Type: bug T-to-reproduce Type: requires reproduction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants