Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipes-devtools: mcumgr: fix binary build #91

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

mike-scott
Copy link
Contributor

The default do_compile() for OE is creating an oddly broken mcumgr
binary. When attempting to upload a new firmware image, mcumgr will
reach 12.9% and then hang for a few seconds before crashing.

First attempts to fix this issue did not work when setting the
following to avoid stripping the end binary:
INHIBIT_PACKAGE_STRIP = "0"

My manual build step looks something like this:
GOOS=linux GOARM=7 GOARCH=arm go build mcumgr.go

Adjusting the mcumgr recipe to mimic my local build steps fixes the
issue.

NOTE: The resulting binary is quite large (~15mb) compared to the
default build which is 1/2 the size.

Signed-off-by: Michael Scott [email protected]

The default do_compile() for OE is creating an oddly broken mcumgr
binary.  When attempting to upload a new firmware image, mcumgr will
reach 12.9% and then hang for a few seconds before crashing.

First attempts to fix this issue did not work when setting the
following to avoid stripping the end binary:
INHIBIT_PACKAGE_STRIP = "0"

My manual build step looks something like this:
GOOS=linux GOARM=7 GOARCH=arm go build mcumgr.go

Adjusting the mcumgr recipe to mimic my local build steps fixes the
issue.

NOTE: The resulting binary is quite large (~15mb) compared to the
default build which is 1/2 the size.

Signed-off-by: Michael Scott <[email protected]>
Copy link
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti ricardosalveti merged commit 0aa8650 into foundriesio:master Oct 23, 2019
@mike-scott mike-scott deleted the fio-fix-mcumgr branch September 23, 2020 06:41
quaresmajose pushed a commit that referenced this pull request Jan 10, 2023
Bumping go-errors to version v0.8.1-32-g5dd12d0, which comprises the following commits:

    5dd12d0 AddingPowerSupport_CI/Testing (#234)
    614d223 Revert "Support Go 1.13 error chains in `Cause` (#215)" (#220)
    49f8f61 Support Go 1.13 error chains in `Cause` (#215)
    004deef remove unnecessary use of fmt.Sprintf (#217)
    6d954f5 feat: support std errors functions (#213)
    7f95ac1 Add support for Go 1.13 error chains (#206)
    91f1693 travis.yml: add Go 1.13
    ca0248e fix travis, 1.10 doesnt support by unconvert anymore
    27936f6 travis.yml: add Go 1.12 (#200)
    856c240 Add json.Marshaler support to the Frame type. (#197)
    ffb6e22 Reduce allocations in StackTrace.Format (#194)
    e9933c1 Restore performance improvements from #150
    ee1923e Return errors.Frame to a uintptr
    72fa05e errors: detect unknown frames correctly (#192)
    c38ea53 Remove errors.Frame to runtime.Frame conversions (#189)
    c9e70be Makefile: switch to staticcheck (#187)
    ee4766c Fix error during merge
    584cbac Remove checks for old style anon funcs (#186)
    42ce1b6 Remove Frame methods (#185)
    937e8c5 gofmt -w
    e19cb69 Remove last reference to runtime.FuncForPC (#184)
    4f47277 Switch to runtime.CallersFrames (#183)
    537896a travis: remove Go 1.8 and earlier (#182)
    31aac83 travis: use Makefile (#181)
    5ac96ae Update README.md
    ba968bf gofmt -w errors.go (#179)
    059132a Update .travis.yml (#168)
    d58f942 Bump Travis versions (#172)
    6ed0a2e Fix StackTrace print example
    2233dee Copyedit the package documentation (#135)
    e981d1a Add WithMessagef function (#118)
    c059e47 fixed spelling (#156)
    816c908 travis.yml: add Go 1.10 (#154)
    e1ac100 reduce allocations when printing stack traces (#149)
    30136e2 Remove deadcode (#146)
    e881fd5 Fix minor typo in README.md (#142)
    8842a6e Add badge for number of dependent libraries (#109)
    e4f5060 Fix doc comment for exported Format func (#137)
    f15c970 Remove an unused argument of utility test func (#139)
    2b3a18b travis: add 1.9.x to go versions (#133)
    c605e28 Add doc comment for exported Format func (#115)
    ff09b13 Bump Go versions, use latest patch releases (#110)
    bfd5150 Move benchmark assigned err to global exported variable (#106)
    248dadf Bump Go versions (#91)

Signed-off-by: Bruce Ashfield <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants