Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recipes-containers: docker-apps: move to 0.6.0 #156

Merged
merged 1 commit into from
Mar 17, 2020
Merged

recipes-containers: docker-apps: move to 0.6.0 #156

merged 1 commit into from
Mar 17, 2020

Conversation

mike-scott
Copy link
Contributor

  • rollback to 0.6.0 to avoid pulling down a cnab container which is used to
    render the docker-compose.yml
  • the cnab and invoc containers gets pruned by aktualizr-lite at the end of
    every update meaning they will be re-downloaded on the next update
  • this complexity isn't really needed as docker-app project seems to have
    stalled out and may never realize the correct abstractions to make all of
    this worth it.
  • simplify, simplify, simplify

Signed-off-by: Michael Scott [email protected]

@mike-scott mike-scott self-assigned this Mar 15, 2020
doanac
doanac reviewed Mar 16, 2020
View reviewed changes
Copy link
Member

@doanac doanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the unused parameters patch will apply cleanly, but it would be nice to keep that functionality around.

@mike-scott
Copy link
Contributor Author

I'm not sure if the unused parameters patch will apply cleanly, but it would be nice to keep that functionality around.

The matchAndMergeParametersDefinition function isn't implemented in docker-app for 0.6.0. Actually, the internal/commands/parameters.go file doesn't exist either. Was there somewhere else I can apply it?

@mike-scott mike-scott force-pushed the master-docker-app-0.6.0 branch from 7c5ca9b to dfe3f3c Compare March 17, 2020 16:46
@mike-scott
Copy link
Contributor Author

Fixed an issue with the .bb file where I was still referencing the 2 patches.

@doanac
Copy link
Member

doanac commented Mar 17, 2020

The matchAndMergeParametersDefinition function isn't implemented in docker-app for 0.6.0. Actually, the internal/commands/parameters.go file doesn't exist either. Was there somewhere else I can apply it?

I just tested v0.6.0 - it doesn't fail on unused parameters. So we are good to go. This was "fixed" in later versions of docker app I guess

ricardosalveti
ricardosalveti reviewed Mar 17, 2020
View reviewed changes
meta-lmp-base/recipes-containers/docker-app/docker-app_git.bb Outdated

inherit go goarch

do_compile() {
cd ${S}/src/${GO_IMPORT}
BUILD_TAG=`git describe --always --abbrev=10`
BUILD_COMMIT=`git rev-parse --short HEAD`
DOCKER_APP_LDFLAGS="-X ${GO_IMPORT}/internal.GitCommit=${BUILD_COMMIT} \
DOCKER_APP_LDFLAGS="-s -w -X ${GO_IMPORT}/internal.GitCommit=${BUILD_COMMIT} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change here to strip during build? OE already calls strip, which is why the insane skip wasn't required before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting an stripping error when I built this as a test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardosalveti testing the new version of this PR locally

@mike-scott mike-scott force-pushed the master-docker-app-0.6.0 branch from dfe3f3c to 2c3f3d7 Compare March 17, 2020 22:36
@mike-scott
recipes-containers: docker-apps: move to 0.6.0
a1f5119 
- rollback to 0.6.0 to avoid pulling down a cnab container which is used to
  render the docker-compose.yml
- the cnab and invoc containers gets pruned by aktualizr-lite at the end of
  every update meaning they will be re-downloaded on the next update
- this complexity isn't really needed as docker-app project seems to have
  stalled out and may never realize the correct abstractions to make all of
  this worth it.
- simplify, simplify, simplify

Signed-off-by: Michael Scott <[email protected]>
@mike-scott mike-scott force-pushed the master-docker-app-0.6.0 branch from 2c3f3d7 to a1f5119 Compare March 17, 2020 23:14
ricardosalveti
ricardosalveti approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti ricardosalveti merged commit 970e0c6 into foundriesio:master Mar 17, 2020
@mike-scott mike-scott deleted the master-docker-app-0.6.0 branch September 23, 2020 06:42
quaresmajose pushed a commit that referenced this pull request Nov 9, 2022
@angolini @ricardosalveti
lmp-bsp: update meta-freescale-3rdparty
7de3c28 
Relevant changes:
- 155ffd6 Merge pull request #189 from boundarydevices/honister
- e8a2af5 linux-boundary: bump revision to acef1311
- fd3c4aa Merge pull request #174 from Ossanes/topic/lx2160acex7-qoriq
- 97b2436 lx2160acex7: Force to use version 5.4 when using linux-qoriq kernel
- 4534c37 Merge pull request #173 from ting-liu/master
- f05d9a0 linux-qoriq_5.4.bb: add as removed in meta-freescale
- 5699179 qoriq-atf_1.5.bb: add as removed in meta-freescale
- a9594a9 Merge pull request #172 from MaxKrummenacher/master
- cc7a94b u-boot-toradex: set uboot_suffix
- 66165d8 layer: manual override syntax fixes
- 72ca672 Merge pull request #170 from chrisdimich/master
- 6d53485 nitrogne8mp: remove obsolete device tree.
- 56f46de linux-boundary: Upgrade to 5.10
- d373302 Merge pull request #168 from chrisdimich/master
- f6da9d6 u-boot-boundary: bump revision to 6ed3b464
- 579e9ee imx-atf-boundary: move to boundary-imx_5.4.70_2.3.0 branch
- 10a3c87 Merge pull request #166 from chrisdimich/master
- 6ca1b4b nitrogen8mp: add device trees
- 9722f85 linux-boundary: bump revision
- 9e56a80 Merge pull request #165 from YoeDistro/yoe/mut
- 79fb14b machines: Adjust for new location of tune files in core
- 1f71611 Merge pull request #163 from chrisdimich/master
- d3336ad nitrogen8mp: update DDR binaries
- 9ab68d1 Merge pull request #161 from chrisdimich/master
- 850d817 nitrogen8mp: define variables needed for imx-boot recipe
- 1de6cbf Merge pull request #157 from texierp/topic/u-boot-fixes
- 7670b84 imx7d-pico: Set UBOOT_SUFFIX to img
- 46c1c81 imx7s-warp: Set UBOOT_SUFFIX to imx
- 4c91b68 Merge pull request #155 from YoeDistro/yoe/mut
- aeaea93 layer.conf: Drop compatibility with older than hardknott releases
- 4ac3c72 layer: Convert to new override syntax
- 8a977f5 Merge pull request #156 from Ossanes/topic/cicd
- 485a417 cicd: backport: Fix events allowing the workflow to run
- 2959439 Merge pull request #153 from ziswiler/master
- 0d6dac1 linux-toradex: update to 4.4.274
- 271ff0d u-boot-toradex: update to latest 2020.07
- de6e95c Merge pull request #152 from Ossanes/topic/cicd-pull-request-target
- 20f7b80 cicd: Use pull_request_target instead of pull_request
- 35acd10 imx6qdl-pico: Remove duplicate MACHINE_FEATURES entry
- da9165a cicd: Add backport workflow
- 5f6c423 imx6qdl-pico: Add QCA9377 Wifi support
- e253f15 imx6qdl-pico: Fix the serial console port

Signed-off-by: Daiane Angolini <[email protected]>
quaresmajose pushed a commit that referenced this pull request Jan 10, 2023
@zeddii
go-errors: update to 0.8.1
0be39c0 
Bumping go-errors to version v0.8.1-32-g5dd12d0, which comprises the following commits:

    5dd12d0 AddingPowerSupport_CI/Testing (#234)
    614d223 Revert "Support Go 1.13 error chains in `Cause` (#215)" (#220)
    49f8f61 Support Go 1.13 error chains in `Cause` (#215)
    004deef remove unnecessary use of fmt.Sprintf (#217)
    6d954f5 feat: support std errors functions (#213)
    7f95ac1 Add support for Go 1.13 error chains (#206)
    91f1693 travis.yml: add Go 1.13
    ca0248e fix travis, 1.10 doesnt support by unconvert anymore
    27936f6 travis.yml: add Go 1.12 (#200)
    856c240 Add json.Marshaler support to the Frame type. (#197)
    ffb6e22 Reduce allocations in StackTrace.Format (#194)
    e9933c1 Restore performance improvements from #150
    ee1923e Return errors.Frame to a uintptr
    72fa05e errors: detect unknown frames correctly (#192)
    c38ea53 Remove errors.Frame to runtime.Frame conversions (#189)
    c9e70be Makefile: switch to staticcheck (#187)
    ee4766c Fix error during merge
    584cbac Remove checks for old style anon funcs (#186)
    42ce1b6 Remove Frame methods (#185)
    937e8c5 gofmt -w
    e19cb69 Remove last reference to runtime.FuncForPC (#184)
    4f47277 Switch to runtime.CallersFrames (#183)
    537896a travis: remove Go 1.8 and earlier (#182)
    31aac83 travis: use Makefile (#181)
    5ac96ae Update README.md
    ba968bf gofmt -w errors.go (#179)
    059132a Update .travis.yml (#168)
    d58f942 Bump Travis versions (#172)
    6ed0a2e Fix StackTrace print example
    2233dee Copyedit the package documentation (#135)
    e981d1a Add WithMessagef function (#118)
    c059e47 fixed spelling (#156)
    816c908 travis.yml: add Go 1.10 (#154)
    e1ac100 reduce allocations when printing stack traces (#149)
    30136e2 Remove deadcode (#146)
    e881fd5 Fix minor typo in README.md (#142)
    8842a6e Add badge for number of dependent libraries (#109)
    e4f5060 Fix doc comment for exported Format func (#137)
    f15c970 Remove an unused argument of utility test func (#139)
    2b3a18b travis: add 1.9.x to go versions (#133)
    c605e28 Add doc comment for exported Format func (#115)
    ff09b13 Bump Go versions, use latest patch releases (#110)
    bfd5150 Move benchmark assigned err to global exported variable (#106)
    248dadf Bump Go versions (#91)

Signed-off-by: Bruce Ashfield <[email protected]>
quaresmajose pushed a commit that referenced this pull request Jan 10, 2023
@zeddii
go-fsnotify: update to v1.5.1
9437f70 
Bumping fsnotify to version v1.5.1-7-gaf855d7

We update the license checksum, due to new copyright dates, and include
the following commits:

    af855d7 Final Notice: Maintainers Wanted
    62a598a maintainers wanted
    d696f5c revise contributing
    6e1d4e4 update readme
    83f9fe6 Test on Go 1.18 and two most recent versions (#411)
    0aba082 Update issue templates (#410)
    3eb7fa4 Removed dead link
    466b39d prepare 1.5.1, retract 1.5.0
    b98ede5 Revert "Add AddRaw to not follow symlinks + Fix link folloing on Windows (#289)"
    dfdb645 revise pull request template
    08848a0 v1.5.0 preparation (#380)
    e2e9517 Add AddRaw to not follow symlinks + Fix link folloing on Windows (#289)
    82ee6f3 Update test matrix for go 1.17 stable release (#385)
    16f0d42 add //go:build lines + add 1.17.0-rc2 to test matrix (#377)
    cc8365b Update x/sys to latest (#379)
    2fb15b1 Drop support/testing for Go 1.11 and earlier (#381)
    5ce1ba4 Remove Travis CI and references
    ed6d2f5 Add lint+vet+old versions to GitHub Action
    42e9219 introduce GitHub Actions
    7f4cf4d Fix unsafe pointer conversion (#325)
    45d7d09 Move example usage to the readme
    4bf2d1f Updating the FAQ section for supportability with NFS & FUSE filesystems.
    dc27d96 drop 1.8.x from Travis CI
    fce5a44 2019
    ecf2c4d revise editor config
    0a05407 Add Go modules
    ab058b4 readme: plan to support fanotify
    924410f Open files with CLOEXEC
    1485a34 Also create epoll and pipe fds with close-on-exec (#155) (#219)
    11844c0 readme: remove AppVeyor badge
    85de84f Add windows to travis matrix
    2216558 Fix lint issue with error doc string
    9152fb1 only run golint on latest version of go
    ccc981b Check if channels are closed in the example (#244)
    1f285c6 darwin tests: Exchangedata is deprecated on 10.13
    7b866c9 travis: less verbose tests
    8ba2b19 [#234] t.Fatalf -> t.Errorf in go routines (#266)
    70cc4a1 Fix TestInotifyOverflow (#265)
    1d13583 TravisCI: updating test versions
    c282820 v1.4.7
    a6f391c travis: test on Go 1.9.x
    ea33dcb Fix missing verb on format string (#228)
    3d33f50 Fix possible deadlock on closing the watcher on kqueue (#230)
    4da3e2c Fix deadlock in Remove (linux/inotify)
    ff7bc41 Watch.Add improvements (avoid race, fix consistency, reduce garbage) (#189)
    7d7316e travis: update for Go 1.8
    a904159 Moved FAQ into the README
    fd9ec7d Properly handle inotify's IN_Q_OVERFLOW event (#149)
    bd2828f replace references to OS X with macOS
    629574c v1.4.2
    abf5e85 pull request and issue template (#179)
    11054bc Create inotify fd with close-on-exec (#178)
    944cff2 v1.4.1
    5c1390e deflake inotify stress test (#177)
    b4f2a68 rm go1.5.4 from travis config since the linter doesn't build in 1.5 (#175)
    c07fd86 readme: remove gocover.io badge
    b3baf18 update link to contributing to external git repos
    26b17cd v1.4.0
    c3181d8 add @oozie to AUTHORS
    55579be Add a String() func to Event.Op (#165)
    f12c623 Bump Travis to Go 1.6.3 (#156)
    a8a77c9 v1.3.1
    51d3cc5 Use filepath.Join() (#153)
    30411db global: switch to x/sys/unix
    836bfd9 Update Travis config to Go 1.5.4 and 1.6.1

Signed-off-by: Bruce Ashfield <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doanac doanac doanac left review comments

@ricardosalveti ricardosalveti ricardosalveti approved these changes

Assignees

@mike-scott mike-scott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mike-scott @doanac @ricardosalveti