fix: Localize Date and Time translations using AM/PM #5748

divyamtayal · 2020-11-25T06:35:21Z

Fixes #5491

Short description of what this resolves:

Time format is changed to 24hr clock whose languages are not supported by moment

Changes proposed in this pull request:

24 hr clock format is shown if AM/PM is not translated to resp language by moment

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

vercel · 2020-11-25T06:35:26Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/dskcvxisg
✅ Preview: https://open-event-frontend-git-trans-date-5491.eventyay.now.sh

codecov · 2020-11-25T06:44:09Z

Codecov Report

Merging #5748 (fe1151a) into development (53ce749) will decrease coverage by 0.05%.
The diff coverage is 57.14%.

@@               Coverage Diff               @@
##           development    #5748      +/-   ##
===============================================
- Coverage        23.50%   23.45%   -0.06%     
===============================================
  Files              512      511       -1     
  Lines             5445     5449       +4     
  Branches            63       63              
===============================================
- Hits              1280     1278       -2     
- Misses            4149     4155       +6     
  Partials            16       16

Impacted Files	Coverage Δ
app/controllers/admin/messages/list.js	`0.00% <ø> (ø)`
app/controllers/admin/sessions/list.js	`0.00% <ø> (ø)`
app/helpers/general-date.js	`66.66% <57.14%> (-33.34%)`	⬇️
app/components/tabbed-navigation.js	`33.33% <0.00%> (-20.00%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ce749...fe1151a. Read the comment docs.

divyamtayal · 2020-11-25T08:29:40Z

Wherever moment was able to convert it into resp language there we are using as it is otherwise 24hr clock.

Some ScreenShots

divyamtayal · 2020-11-25T08:39:35Z

mariobehling · 2020-11-25T09:13:19Z

Thank you. Could you change the following, please:

no space in front of any commas
change 0:00 to 24:00

divyamtayal · 2020-11-25T09:20:00Z

change 0:00 to 24:00

@mariobehling
change as in change date or format (H:mm to HH:mm) ?

iamareebjamal · 2020-11-25T09:57:49Z

We won't be able to change 0:00 to 24:00, that is controlled by moment JS AFAIK

divyamtayal · 2020-11-25T09:58:11Z

We won't be able to change 0:00 to 24:00, that is controlled by moment JS AFAIK

exactly

.env.example

app/helpers/general-date.js

iamareebjamal · 2020-11-25T10:00:44Z

I think there will be conflicting changes in this PR and standardize PR, please work with @maze-runnar to finalize that PR and then work on this PR

app/helpers/general-date.js

divyamtayal · 2020-11-27T05:44:05Z

@iamareebjamal Pls see the changes, improved the format wherever not standardized, and also replaced everything with general-date.
Pls, let me know to make any changes further.

app/helpers/general-date.js

app/components/ui-table/cell/cell-date.hbs

This reverts commit 70f296c.

divyamtayal · 2020-11-27T10:40:58Z

@iamareebjamal This is done now with all the changes said by you.

app/templates/components/event-invoice/event-info.hbs

iamareebjamal · 2020-11-27T19:57:43Z

app/templates/components/event-invoice/event-info.hbs

@@ -12,9 +12,9 @@
  <div class="ui padded segment">
    <strong>{{t 'At'}} {{this.event.locationName}}</strong>
    <br>
-    <strong>{{t 'From'}}:</strong> {{header-date this.event.startsAt}}
+    <strong>{{t 'From'}}:</strong> {{general-date this.event.startsAt '' 'dddd, D MMMM, YYYY h:mm A'}}


I don't remember, was this the standard format which was chosen?

What I found in #5747 is that at some places still time format is not standardized like format is not consistent

Please create a Pr to fix that as well

Start

23e7c0f

vercel bot deployed to Preview November 25, 2020 06:35 View deployment

Merge branch 'development' into trans-date-5491

ad17eba

vercel bot deployed to Preview November 25, 2020 06:35 View deployment

Changed to 24h

8760c75

vercel bot deployed to Preview November 25, 2020 08:27 View deployment

Changed to 24h-1

f07c128

Fix test

8c324bf

vercel bot deployed to Preview November 25, 2020 09:17 View deployment

mariobehling mentioned this pull request Nov 25, 2020

fix: time standardization in two formats only #5747

Merged

18 tasks

iamareebjamal reviewed Nov 25, 2020

View reviewed changes

.env.example Outdated Show resolved Hide resolved

iamareebjamal reviewed Nov 25, 2020

View reviewed changes

app/helpers/general-date.js Outdated Show resolved Hide resolved

Update .env.example

e71f3a1

vercel bot deployed to Preview November 25, 2020 10:00 View deployment

Merge branch 'development' into trans-date-5491

130bd01

vercel bot deployed to Preview November 25, 2020 11:31 View deployment

Improved Code

03aa56f

divyamtayal requested a review from iamareebjamal November 25, 2020 11:33

vercel bot deployed to Preview November 25, 2020 11:35 View deployment

iamareebjamal reviewed Nov 25, 2020

View reviewed changes

app/helpers/general-date.js Outdated Show resolved Hide resolved

Improved code-1

f06a783

vercel bot deployed to Preview November 27, 2020 05:23 View deployment

Improved Date format

b4647d7

vercel bot deployed to Preview November 27, 2020 05:42 View deployment

Deleted header-date helper

ff36d5f

vercel bot deployed to Preview November 27, 2020 05:45 View deployment

Fixed Test

888122f

vercel bot deployed to Preview November 27, 2020 05:57 View deployment

iamareebjamal reviewed Nov 27, 2020

View reviewed changes

app/helpers/general-date.js Outdated Show resolved Hide resolved

Revert default format

64bde57

vercel bot deployed to Preview November 27, 2020 06:51 View deployment

iamareebjamal reviewed Nov 27, 2020

View reviewed changes

app/components/ui-table/cell/cell-date.hbs Outdated Show resolved Hide resolved

Revert changes

70f296c

vercel bot deployed to Preview November 27, 2020 10:38 View deployment

daretobedifferent18 added 2 commits November 27, 2020 16:08

Revert "Revert changes"

fe0a542

This reverts commit 70f296c.

Finalizing the PR

d6909bf

vercel bot deployed to Preview November 27, 2020 10:41 View deployment

Deleted header-date helper

fdc6fc0

vercel bot deployed to Preview November 27, 2020 10:45 View deployment

divyamtayal requested a review from iamareebjamal November 27, 2020 10:46

iamareebjamal reviewed Nov 27, 2020

View reviewed changes

app/templates/components/event-invoice/event-info.hbs Outdated Show resolved Hide resolved

Added format for all replaced header-date

fe1151a

vercel bot deployed to Preview November 27, 2020 19:53 View deployment

divyamtayal requested a review from iamareebjamal November 27, 2020 19:55

iamareebjamal reviewed Nov 27, 2020

View reviewed changes

iamareebjamal changed the title ~~Date and Time translations using AM/PM~~ fix: Localize Date and Time translations using AM/PM Nov 27, 2020

auto-label bot added the fix label Nov 27, 2020

iamareebjamal merged commit e80b30f into fossasia:development Nov 27, 2020

divyamtayal deleted the trans-date-5491 branch November 27, 2020 20:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Localize Date and Time translations using AM/PM #5748

fix: Localize Date and Time translations using AM/PM #5748

divyamtayal commented Nov 25, 2020 •

edited

Loading

vercel bot commented Nov 25, 2020 •

edited

Loading

codecov bot commented Nov 25, 2020 •

edited

Loading

divyamtayal commented Nov 25, 2020

divyamtayal commented Nov 25, 2020

mariobehling commented Nov 25, 2020

divyamtayal commented Nov 25, 2020 •

edited

Loading

iamareebjamal commented Nov 25, 2020

divyamtayal commented Nov 25, 2020

iamareebjamal commented Nov 25, 2020

divyamtayal commented Nov 27, 2020

divyamtayal commented Nov 27, 2020

iamareebjamal Nov 27, 2020

divyamtayal Nov 27, 2020

divyamtayal Nov 27, 2020 •

edited

Loading

iamareebjamal Nov 27, 2020

fix: Localize Date and Time translations using AM/PM #5748

fix: Localize Date and Time translations using AM/PM #5748

Conversation

divyamtayal commented Nov 25, 2020 • edited Loading

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

vercel bot commented Nov 25, 2020 • edited Loading

codecov bot commented Nov 25, 2020 • edited Loading

Codecov Report

divyamtayal commented Nov 25, 2020

divyamtayal commented Nov 25, 2020

mariobehling commented Nov 25, 2020

divyamtayal commented Nov 25, 2020 • edited Loading

iamareebjamal commented Nov 25, 2020

divyamtayal commented Nov 25, 2020

iamareebjamal commented Nov 25, 2020

divyamtayal commented Nov 27, 2020

divyamtayal commented Nov 27, 2020

iamareebjamal Nov 27, 2020

Choose a reason for hiding this comment

divyamtayal Nov 27, 2020

Choose a reason for hiding this comment

divyamtayal Nov 27, 2020 • edited Loading

Choose a reason for hiding this comment

iamareebjamal Nov 27, 2020

Choose a reason for hiding this comment

divyamtayal commented Nov 25, 2020 •

edited

Loading

vercel bot commented Nov 25, 2020 •

edited

Loading

codecov bot commented Nov 25, 2020 •

edited

Loading

divyamtayal commented Nov 25, 2020 •

edited

Loading

divyamtayal Nov 27, 2020 •

edited

Loading