-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: time standardization in two formats only #5747
fix: time standardization in two formats only #5747
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/pmyrykl4r |
Codecov Report
@@ Coverage Diff @@
## development #5747 +/- ##
============================================
Coverage 23.50% 23.50%
============================================
Files 512 512
Lines 5459 5459
Branches 62 62
============================================
Hits 1283 1283
Misses 4160 4160
Partials 16 16
Continue to review full report at Codecov.
|
Please also change using long version on:
|
Looks like you are changing the time format to 24 hours and show e.g. 13:00 PM. Please use standard time format and we need to take care that this is different in different languages. |
Yes, there are far fewer changes in this PR than the previous one. Please keep all changes from the previous PR and fix the wrong things |
@@ -9,9 +9,9 @@ | |||
<img src="{{this.model.logoUrl}}" class="logo mr-8" /> | |||
{{/if}} | |||
<div> | |||
<h4 class="event time">{{header-date this.model.startsAt this.model.timezone}}</h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why changed to general
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to move to a single helper, general-date
@@ -35,7 +35,7 @@ export default class extends Controller.extend(EmberTableControllerMixin) { | |||
cellComponent : 'ui-table/cell/events/view/tickets/orders/cell-date', | |||
headerComponent : 'tables/headers/sort', | |||
width : 100, | |||
dateFormat : 'MMMM DD, YYYY - HH:mm A', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls also correct this declaration, here I think we need to define dateFormat inside options as an object
Fixes #5490
Make event format as in this example: 4 Dec, 2020 5:00 PM (IST)
This is good for most public pages
call for speakers, e.g. https://eventyay.com/e/a315169f/cfs
Checklist
development
branch.