Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the icon of the Acknowledgement #5630

Merged
merged 3 commits into from
Nov 15, 2020

Conversation

Raunaksingh100
Copy link
Member

@Raunaksingh100 Raunaksingh100 commented Nov 15, 2020

Fixes #5629

Short description of what this resolves:

change the icon for acknowledgement is the same as for ticket holder see in the screenshot for the better understanding.

screenshot before-

before

screenshot after-

2

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 15, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/c137h0ckw
✅ Preview: https://open-event-frontend-git-patch-2.eventyay.vercel.app

@Raunaksingh100
Copy link
Member Author

@iamareebjamal can you review this pr

@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #5630 (8b7d66c) into development (8589e82) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5630   +/-   ##
============================================
  Coverage        23.73%   23.73%           
============================================
  Files              498      498           
  Lines             5275     5275           
  Branches            47       47           
============================================
  Hits              1252     1252           
  Misses            4015     4015           
  Partials             8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8589e82...8b7d66c. Read the comment docs.

@mariobehling
Copy link
Member

I found one that seems more suitable
Please use this one https://fontawesome.com/icons/tasks?style=regular

@Raunaksingh100
Copy link
Member Author

Raunaksingh100 commented Nov 15, 2020

I found one that seems more suitable
Please use this one https://fontawesome.com/icons/tasks?style=regular

@mariobehling and @iamareebjamal i updated the code can you review ??

Copy link
Contributor

@sachinchauhan2889 sachinchauhan2889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me.

@mariobehling mariobehling merged commit 117f110 into fossasia:development Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order Process Pages: Choose better icon for "Acknowledgement"
3 participants