Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change edit endpoints in router #4699

Merged
merged 3 commits into from
Aug 4, 2020

Conversation

divs4debu
Copy link
Contributor

@divs4debu divs4debu commented Aug 2, 2020

Fixes #4685

Short description of what this resolves:

Changes proposed in this pull request:

  • changes order for session edit url

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/179zydu23
✅ Preview: https://open-event-frontend-git-fork-divs4debu-standardizeurl.eventyay.vercel.app

@divs4debu divs4debu changed the title WIP fix: Change order of edit endpoint for sessions [WIP] fix: Change order of edit endpoint for sessions Aug 2, 2020
@codecov
Copy link

codecov bot commented Aug 2, 2020

Codecov Report

Merging #4699 into development will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4699      +/-   ##
===============================================
- Coverage        23.11%   23.08%   -0.03%     
===============================================
  Files              476      476              
  Lines             4975     4981       +6     
  Branches             8        8              
===============================================
  Hits              1150     1150              
- Misses            3824     3830       +6     
  Partials             1        1              
Impacted Files Coverage Δ
app/router.js 100.00% <100.00%> (ø)
app/components/forms/wizard/basic-details-step.js 24.39% <0.00%> (-0.31%) ⬇️
app/mixins/event-wizard.js 1.14% <0.00%> (-0.08%) ⬇️
app/sentry.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9929ad...2517dfe. Read the comment docs.

@iamareebjamal
Copy link
Member

@divs4debu Status?

@divs4debu
Copy link
Contributor Author

I have added commit for cfs links, still working on basic-details

@divs4debu divs4debu changed the title [WIP] fix: Change order of edit endpoint for sessions fix: Change edit endpoints in router Aug 4, 2020
@auto-label auto-label bot added the fix label Aug 4, 2020
@divs4debu
Copy link
Contributor Author

I have changed all the routes except the one's that require folder structure changes

@iamareebjamal iamareebjamal merged commit b0c565b into fossasia:development Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize URLs and edit URLs
2 participants