Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize URLs and edit URLs #4685

Closed
mariobehling opened this issue Jul 31, 2020 · 5 comments · Fixed by #4699
Closed

Standardize URLs and edit URLs #4685

mariobehling opened this issue Jul 31, 2020 · 5 comments · Fixed by #4699

Comments

@mariobehling
Copy link
Member

URLs are not well standardized in the system. Many system show a "node" and provide an option to edit a node by attaching /edit.

Please implement the same for URLs in the system such as

@divs4debu
Copy link
Contributor

working on it

@divs4debu
Copy link
Contributor

I have completed for sessions end point. Currently working for basic-details.

@iamareebjamal
Copy link
Member

iamareebjamal commented Aug 4, 2020

eventyay.com/events/5ac8e4d9/edit/basic-details to eventyay.com/events/5ac8e4d9/basic-details/edit and similar changes for routes under events/<id>/edit will require major architectural changes as each section is nested under edit route and has specific code calls under this route. Is this change very necessary @mariobehling ?

@mariobehling
Copy link
Member Author

Ok, lets move it to lower priority and discuss this later. It was just confusing to me to see different structures like sessions/edit/6255 and cfs/edit/session/6255. I dont understand why similar functionality has a different URL structure.

@mariobehling mariobehling removed this from the Foms and Custom Forms milestone Aug 5, 2020
@mariobehling
Copy link
Member Author

But it seems @divs4debu is able to make this work. So, please proceed as you see fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants