Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delete complex field values if empty #4665

Merged

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Jul 30, 2020

@auto-label auto-label bot added the fix label Jul 30, 2020
@vercel
Copy link

vercel bot commented Jul 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/6in8fa8uv
✅ Preview: https://open-event-fro-git-fork-iamareebjamal-complex-field-valu-12853e.eventyay.vercel.app

Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/serializers/session.js  2
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #4665 into development will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4665      +/-   ##
===============================================
- Coverage        23.08%   23.03%   -0.05%     
===============================================
  Files              475      476       +1     
  Lines             4952     4962      +10     
  Branches             8        8              
===============================================
  Hits              1143     1143              
- Misses            3808     3818      +10     
  Partials             1        1              
Impacted Files Coverage Δ
app/serializers/session.js 0.00% <0.00%> (ø)
app/controllers/events/view.js 0.00% <0.00%> (ø)
app/components/public/call-for-speakers.js 0.00% <0.00%> (ø)
app/components/modals/cfs-proposal-modal.js
app/components/modals/publish-unpublish-modal.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf66cf...ca46e3e. Read the comment docs.

@iamareebjamal iamareebjamal merged commit a303486 into fossasia:development Jul 30, 2020
@iamareebjamal iamareebjamal deleted the complex-field-values-session branch July 30, 2020 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants