Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving session and speaker fails if created before addition of custom form #7164

Closed
iamareebjamal opened this issue Jul 27, 2020 · 2 comments · Fixed by #7172
Closed

Saving session and speaker fails if created before addition of custom form #7164

iamareebjamal opened this issue Jul 27, 2020 · 2 comments · Fixed by #7172

Comments

@iamareebjamal
Copy link
Member

If a speaker or session was created before addition of a required custom form, then it is impossible to send a PATCH request to edit them since new required field is not present in the request. So, custom form required checks must only be applied if either speaker or session is being created or custom form values are present in the PATCH request

@iamareebjamal
Copy link
Member Author

In a PATCH request:

  • If complex field values are present
    • Apply validation
  • If complex field values are null or {}
    • Apply validation if previously there were complex field values assigned
  • If complex field values are absent
    • Don't apply validation

@iamareebjamal
Copy link
Member Author

It is becoming more and more complicated just for the sake of allowing organizer to edit status.

I think it's better if we allow organizers to edit session as they see fit and apply normal validations for speakers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant