Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove my-sessions from organizer view session route #4629

Merged
merged 8 commits into from
Jul 27, 2020

Conversation

Haider8
Copy link
Contributor

@Haider8 Haider8 commented Jul 24, 2020

Fixes #4590

Short description of what this resolves:

Organizer's view session route was directing to my-sessions/... route which is not what we need.

Changes proposed in this pull request:

Instead direct it to /e/:event_id/sessions/:session_id

view-session-route

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jul 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/1lzybwf22
✅ Preview: https://open-event-frontend-git-fork-haider8-issue-4590.eventyay.vercel.app

@Haider8
Copy link
Contributor Author

Haider8 commented Jul 25, 2020

@iamareebjamal Please review

app/router.js Outdated
@@ -42,6 +42,7 @@ Router.map(function() {
this.route('public', { path: '/e/:event_id' }, function() {
this.route('sessions', function() {
this.route('list', { path: '/s/:session_status' });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/session/, not /s/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I remove /s? Because after that the route will become sessions/:session_status

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Please review

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #4629 into development will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4629   +/-   ##
============================================
  Coverage        23.04%   23.04%           
============================================
  Files              475      475           
  Lines             4959     4959           
  Branches             8        8           
============================================
  Hits              1143     1143           
  Misses            3815     3815           
  Partials             1        1           
Impacted Files Coverage Δ
app/controllers/events/view/sessions/list.js 0.00% <0.00%> (ø)
app/controllers/public/sessions/view.js 0.00% <ø> (ø)
app/routes/public/sessions/view.js 0.00% <ø> (ø)
app/router.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 579db43...a6a6cf9. Read the comment docs.

@iamareebjamal iamareebjamal merged commit c66b5aa into fossasia:development Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organizer Sessions Tab: View and edit option directing to "my-sessions/..."
2 participants