Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organizer Sessions Tab: View and edit option directing to "my-sessions/..." #4590

Closed
mariobehling opened this issue Jul 20, 2020 · 4 comments · Fixed by #4629
Closed

Organizer Sessions Tab: View and edit option directing to "my-sessions/..." #4590

mariobehling opened this issue Jul 20, 2020 · 4 comments · Fixed by #4629

Comments

@mariobehling
Copy link
Member

The view and edit options on the "sessions tab" of organizers direct to a link "my-sessions...". Expected: The link structure to view and edit sessions as an organizer should be in the structure of https://eventyay.com/events/[event-ID]/sessions/[session-ID]

Screenshot from 2020-07-20 21-08-42

@iamareebjamal
Copy link
Member

Edit option leads to https://eventyay.com/events/<event_id>/sessions/edit/<session_id> but view option indeed leads to my-sessions. Should the my-session URL be changed to https://eventyay.com/events/[event-ID]/sessions/[session-ID] for user/speaker as well? If not, same view will be shown at 2 different URLs, leading to maintainence issues

@mariobehling
Copy link
Member Author

mariobehling commented Jul 20, 2020

Should the my-session URL be changed to https://eventyay.com/events/[event-ID]/sessions/[session-ID] for user/speaker as well? If not, same view will be shown at 2 different URLs, leading to maintainence issues

Yes, agree. I understand that you want to change the personal URL as well for maintenance issues. I think it would be more suitable than the current version, cause an organizer should not have a session of a speaker of an event under the "my sessions" URL.

And we need to consider this even further, cause the edit sessions form also show up in a URL related to the CfS, e.g. https://eventyay.com/e/0917096d/cfs/edit/6255 vs. the session edit form of the organizer: https://eventyay.com/events/0917096d/sessions/edit/6255

The difference is: The organizer has the option to add a speaker though. We also need the "invite option" for a second and third speaker back (we took it out as it was buggy). So, except for this feature the forms are same.

Screenshot from 2020-07-20 22-03-46

What is the best thing to do?

@iamareebjamal
Copy link
Member

iamareebjamal commented Jul 21, 2020

I think we keep all URLs for organizer same as most of the things are same and use CFS URL for speaker edit as it is a different view even if most things are same. This will mean that speakers will not be able to see the admin view even if there's a bug in the UI.

So, for organizers - https://eventyay.com/events/0917096d/sessions/edit/6255
For users (public URL) - https://eventyay.com/e/0917096d/cfs/edit/session/6255

This way we have ensured that all events/* URLs are for organizers/admin only and /e/* are for public. But we should definitely use same URL for my session edit and CFS edit as they are exactly same

@iamareebjamal
Copy link
Member

iamareebjamal commented Jul 22, 2020

@Haider8 View Session URL - /e/<event_id>/sessions/<session_id>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants