Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include root when using glob patterns #681

Closed
1 task done
gnikit opened this issue Sep 28, 2022 · 0 comments · Fixed by #682
Closed
1 task done

feat: include root when using glob patterns #681

gnikit opened this issue Sep 28, 2022 · 0 comments · Fixed by #682
Assignees

Comments

@gnikit
Copy link
Member

gnikit commented Sep 28, 2022

Is there an existing request for this?

  • I have searched the existing issues

Feature Request

doing something like ${workspaceFolder}/include/** does not include ${workspaceFolder}/include. This is a bug by fast-glob mrmlnc/fast-glob#47 but it interferes with how users interact with our extension so the only solution is for us to drop fast-glob as a dependency and use the slower glob module.

Because we use caching the difference between the 2 should be almost unnoticed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant