With onlyFiles: false directories at the root are not included

[pvdlg]

With the following directory tree:

+-- test/
|   +-- dir
|       +-- file.js

fg.sync('test/**', {onlyFiles: false});

// Result => ['test/dir/', 'test/dir/file.js']
// Should be => ['test', 'test/dir', 'test/dir/file.js']

For example with node-glob:

glob.sync('test/**', {nodir: false});

// Result => ['test', 'test/dir', 'test/dir/file.js']

[dylang]

I'm not sure if this is the same issue:

+ fixtures
  + dir1
  + dir2

// I expect this to return [ 'dir1', 'dir2' ]
// and it does
const results = await glob(['fixtures/*'], { onlyDirectories: true });

// I expect this to return [ 'fixtures' ],
// but it returns [ ]
const results = await glob(['fixtures'], { onlyDirectories: true });

[mrmlnc]

Hello, @dylang,

Looks like separated issue. Please create a issue for your problem.

I can say right now, that this is works on my machine:

tree fixtures/
fixtures/
├── b
│   └── c
│       ├── md.md
│       └── txt.txt
├── md.md
└── txt.txt

const fg = require('fast-glob');

const entries0 = fg.sync(['fixtures/*'], { onlyDirectories: true });

console.dir(entries0, { colors: true });  // [ 'fixtures/b' ]

const entries1 = fg.sync(['fixtures'], { onlyDirectories: true });

console.dir(entries1, { colors: true });  // [ 'fixtures' ]

Are you sure you're using the latest version of the package? But I need more information about your case. Your version of the fast-glob package, OS and etc.

[dylang]

@mrmlnc You are correct, older version via globby at fault, thanks for the quick reply!

[mrmlnc]

Blocked by migrate to @nodelib/fs.walk (nodelib/nodelib#9).

[lcrespom]

I am executing this code:

const glob = require('fast-glob').sync
console.log(glob('/*', { onlyFiles: false }))

And I get [] as the output. I am using MacOS and v12.14.0.
I think this problem is related with this issue, but maybe it's a different one.

[mrmlnc]

@lcrespom,

Nope, if you want to get only directories, then you need to use the onlyDirectories option. When you disable the onlyFiles option the onlyDirectories option is not automatically enabled.

[lcrespom]

I don't want only directories, I want to get all dirs and files of my root directory, but instead I am getting an empty array, and I can assure you my root directory is not empty.

P.S. even if I wanted only directories, I have just tested this code:

const glob = require('fast-glob').sync
console.log(glob('/*', { onlyFiles: false, onlyDirectories: true }))

...and it also displays [].

[75lb]

Any update on a fix for this? This issue is preventing me switching to fast-glob from node-glob (without a breaking change)..

$ tree
.
├── 1
│   ├── one
│   └── two
│       └── three

$ echo 1/**
1/ 1/one 1/two 1/two/three

$ node
Welcome to Node.js v16.2.0.
> fg = require('fast-glob')
> fg.sync(['1/**'], { onlyFiles: false })
[ '1/one', '1/two', '1/two/three' ]

As you can see in the example above, bash expands 1/** to four paths while fast-glob only expands to three paths ('1/' is missing).