Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/unify sql store #94

Merged
merged 7 commits into from
Dec 22, 2021
Merged

feature/unify sql store #94

merged 7 commits into from
Dec 22, 2021

Conversation

gfyrag
Copy link
Contributor

@gfyrag gfyrag commented Dec 21, 2021

  • Refactor storage to reduce duplicate code between different sql engines.
  • Add some utils for testing

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #94 (fd52a25) into main (ec716fa) will increase coverage by 29.30%.
The diff coverage is 65.24%.

❗ Current head fd52a25 differs from pull request most recent head 21406f9. Consider uploading reports for the commit 21406f9 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main      #94       +/-   ##
===========================================
+ Coverage   10.37%   39.68%   +29.30%     
===========================================
  Files          45       39        -6     
  Lines        1947     1517      -430     
===========================================
+ Hits          202      602      +400     
+ Misses       1732      867      -865     
- Partials       13       48       +35     
Impacted Files Coverage Δ
cmd/root.go 0.00% <0.00%> (ø)
cmd/ui.go 0.00% <ø> (ø)
config/config.go 0.00% <0.00%> (-46.81%) ⬇️
storage/driver.go 100.00% <ø> (ø)
storage/sqlstorage/store.go 73.33% <73.33%> (ø)
storage/sqlstorage/metadata.go 77.77% <81.81%> (ø)
storage/sqlstorage/driver.go 84.61% <84.61%> (ø)
storage/sqlstorage/transactions.go 86.51% <90.47%> (ø)
storage/sqlstorage/accounts.go 86.04% <100.00%> (ø)
storage/sqlstorage/aggregations.go 87.67% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed5e4db...21406f9. Read the comment docs.

@gfyrag gfyrag force-pushed the feature/unify-sql-store branch from 214d277 to 9226ee8 Compare December 22, 2021 11:06
@gfyrag gfyrag force-pushed the feature/unify-sql-store branch from 9226ee8 to 93101d5 Compare December 22, 2021 12:32
@flemzord flemzord requested review from flemzord and altitude and removed request for reslene December 22, 2021 12:49
storage/sqlstorage/driver.go Outdated Show resolved Hide resolved
storage/sqlstorage/driver.go Outdated Show resolved Hide resolved
@flemzord flemzord merged commit 65d176e into main Dec 22, 2021
@flemzord flemzord deleted the feature/unify-sql-store branch December 22, 2021 14:52
@flemzord flemzord restored the feature/unify-sql-store branch December 22, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants