Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feature/unify sql store" #112

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Revert "feature/unify sql store" #112

merged 1 commit into from
Dec 22, 2021

Conversation

flemzord
Copy link
Member

Reverts #94

@flemzord flemzord requested a review from a team as a code owner December 22, 2021 17:26
@flemzord flemzord requested a review from gfyrag December 22, 2021 17:26
@codecov
Copy link

codecov bot commented Dec 22, 2021 •
edited
Loading

Codecov Report

Merging #112 (70c8cd9) into main (fd52a25) will decrease coverage by 30.43%.
The diff coverage is 2.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #112       +/-   ##
==========================================
- Coverage   39.68%   9.24%   -30.44%     
==========================================
  Files          39      45        +6     
  Lines        1517    1946      +429     
==========================================
- Hits          602     180      -422     
- Misses        867    1755      +888     
+ Partials       48      11       -37
Impacted Files Coverage Δ
api/controllers/transaction_controller.go 2.04% <ø> (ø)
cmd/root.go 0.00% <0.00%> (ø)
storage/driver.go 100.00% <ø> (ø)
storage/postgres/accounts.go 0.00% <0.00%> (ø)
storage/postgres/aggregations.go 0.00% <0.00%> (ø)
storage/postgres/metadata.go 0.00% <0.00%> (ø)
storage/postgres/transactions.go 0.00% <0.00%> (ø)
storage/sqlite/accounts.go 0.00% <0.00%> (ø)
storage/sqlite/aggregations.go 0.00% <0.00%> (ø)
storage/sqlite/driver.go 0.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eef062...70c8cd9. Read the comment docs.

@flemzord flemzord merged commit d743e16 into main Dec 22, 2021
@flemzord flemzord deleted the revert-94-feature/unify-sql-store branch December 22, 2021 17:29
gfyrag added a commit that referenced this pull request Dec 23, 2021
@gfyrag
Revert "Merge pull request #112 from numary/revert-94-feature/unify-s…
b1d14fb 
…ql-store"

This reverts commit d743e16, reversing
changes made to 6eef062.
flemzord pushed a commit that referenced this pull request Jun 7, 2023
@gfyrag @flemzord
feat: use pgtesting from go libs (#112)
9a0a03d
flemzord pushed a commit that referenced this pull request Sep 20, 2023
@gfyrag @flemzord
feat: use pgtesting from go libs (#112)
f2ddbc9
flemzord pushed a commit that referenced this pull request Dec 4, 2023
@gfyrag @flemzord
feat: use pgtesting from go libs (#112)
5965a55
flemzord pushed a commit that referenced this pull request Sep 25, 2024
@gfyrag @flemzord
feat: use pgtesting from go libs (#112)
20bbc4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altitude altitude altitude approved these changes

@gfyrag gfyrag Awaiting requested review from gfyrag gfyrag was automatically assigned from formancehq/core

Assignees
No one assigned
Labels
@domain/cmd @domain/ledger @domain/storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flemzord @altitude