Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always send deploy event and fix telemetry for mdapi deploy #797

Merged
merged 3 commits into from
Dec 13, 2022

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Dec 13, 2022

What does this PR do?

Emits events for telemetry and API version when mdapi:deploy commands are executed. Exports the API version event data types.

What issues does this PR fix or reference?

@W-12146860@

Functionality Before

  1. An event with API version data was not fired for mdapi:deploy command deploys
  2. Telemetry data was not being sent for mdapi:deploy command deploys (due to an exception being thrown)

Functionality After

Both of the above events are emitted properly.

@shetzel shetzel requested review from a team as code owners December 13, 2022 21:01
@mshanemc
Copy link
Contributor

QA notes:

mdapi with config set to a version
✅ Deploying v53.0 metadata to [email protected] using the v52.0 SOAP API

without config override:
✅ Deploying v53.0 metadata to [email protected] using the v56.0 SOAP API

SFDX_API_VERSION=55.0 ../../plugin-source/bin/dev force:source:deploy -x mdapiOut/package.xml
✅ Deploying v53.0 metadata to [email protected] using the v55.0 SOAP API

../../plugin-source/bin/dev force:mdapi:deploy -d mdapiOut
✅ Deploying metadata to [email protected] using the v56.0 SOAP API

@mshanemc mshanemc merged commit 42ab03e into main Dec 13, 2022
@mshanemc mshanemc deleted the sh/deploy-api-version-fixes branch December 13, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants