Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the right glyphset checked for minimal glyphs coverage? #3583

Closed
RosaWagner opened this issue Feb 2, 2022 · 6 comments
Closed

Is the right glyphset checked for minimal glyphs coverage? #3583

RosaWagner opened this issue Feb 2, 2022 · 6 comments
Assignees
Milestone

Comments

@RosaWagner
Copy link
Contributor

Last update of Fontbakery brought a bunch of missing codepoints that are actually not required in GF Latin Core.

In report for ABeeZee I got these fails:
(google/fonts#4227 (comment))

🔥 FAIL: Check `Google Fonts Latin Core` glyph coverage.
com.google.fonts/check/glyph_coverage
--- Rationale ---
Google Fonts expects that fonts in its collection support at least the minimal
set of characters defined in the `GF-latin-core` glyph-set.
🔥 FAIL Missing required codepoints:

0x02BB (MODIFIER LETTER TURNED COMMA)

0x02BC (MODIFIER LETTER APOSTROPHE)

0x2002 (EN SPACE)

0x2009 (THIN SPACE)

0x200B (ZERO WIDTH SPACE)

0x2032 (PRIME)

0x2033 (DOUBLE PRIME)

0x2122 (TRADE MARK SIGN)

0x2191 (UPWARDS ARROW)

0x2193 (DOWNWARDS ARROW)

0xFEFF (ZERO WIDTH NO-BREAK SPACE)

And 0xFFFD (REPLACEMENT CHARACTER)
[code: missing-codepoints]

None of those are in:
https://github.com/googlefonts/glyphsets/blob/main/Lib/glyphsets/encodings/GF%20Glyph%20Sets/GF-latin-core_unique-glyphs.nam

--> Fontbakery should check Latin Core, and not another one.

@felipesanches felipesanches self-assigned this Feb 2, 2022
@felipesanches felipesanches added this to the 0.8.7 milestone Feb 2, 2022
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Feb 4, 2022
Use the correct nam-file for checking coverage of the GF-latin-core glyphset

com.google.fonts/check/glyph_coverage
(issue fonttools#3583)
felipesanches added a commit that referenced this issue Feb 4, 2022
Use the correct nam-file for checking coverage of the GF-latin-core glyphset

com.google.fonts/check/glyph_coverage
(issue #3583)
@RosaWagner
Copy link
Contributor Author

Having this issue with 0.8.7

Soft-hyphen and division slash are not in the nam file anymore. So I wonder if we are now using the last version of the glyphset.

🔥 FAIL: Check `Google Fonts Latin Core` glyph coverage.
* [com.google.fonts/check/glyph_coverage](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/glyph_coverage)
🔥 FAIL Missing required codepoints:

0x00AD (SOFT HYPHEN)

0x00AF (MACRON)

0x2074 (SUPERSCRIPT FOUR)

And 0x2215 (DIVISION SLASH) [code: missing-codepoints]

@felipesanches
Copy link
Collaborator

I will review this.

@felipesanches felipesanches reopened this Mar 3, 2022
@felipesanches felipesanches modified the milestones: 0.8.7, 0.8.9, 0.8.8 Mar 14, 2022
@felipesanches
Copy link
Collaborator

I'm sorry, I'll have to postpone this to the next release because #3675 is critical and urgently requires a new release as it is already fixed on git.

@felipesanches felipesanches modified the milestones: 0.8.8, 0.8.9 Mar 23, 2022
@felipesanches
Copy link
Collaborator

The recent work by @RosaWagner and @m4rc1e at #3753 is supposed to have fixed this. Please reopen the issue otherwise.

@vv-monsalve
Copy link
Collaborator

Inspecting this FB report, I see division slash is still reported as missing. Is the check using the latest .nam file?

@vv-monsalve
Copy link
Collaborator

I've seen the FB version was 0.8.8.dev29+g809e15c6 so closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants