Skip to content

Commit

Permalink
Fix glyph_coverage check
Browse files Browse the repository at this point in the history
Use the correct nam-file for checking coverage of the GF-latin-core glyphset

com.google.fonts/check/glyph_coverage
(issue #3583)
  • Loading branch information
felipesanches committed Feb 4, 2022
1 parent 51502ff commit 3af9f83
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ A more detailed list of changes is available in the corresponding milestones for
#### On the Google Fonts Profile
- **[com.google.fonts/check/name/familyname]:** Consider camel-case exceptions (issue #3584)
- **[com.google.fonts/check/name/fullfontname]:** Consider camel-case exceptions (issue #3584)
- **[com.google.fonts/check/glyph_coverage]:** Use the correct nam-file for checking coverage of the GF-latin-core glyphset (issue #3583)

#### Migrations
- **[com.google.fonts/check/transformed_components]:** moved from `Google Fonts` profile to `Universal` profile. It is not strictly a Google Fonts related check as transformed components cause problems in various rendering environments. (issue #3588)
Expand Down
7 changes: 5 additions & 2 deletions Lib/fontbakery/profiles/googlefonts.py
Original file line number Diff line number Diff line change
Expand Up @@ -990,10 +990,13 @@ def font_codepoints(ttFont):
def com_google_fonts_check_glyph_coverage(ttFont, font_codepoints, config):
"""Check `Google Fonts Latin Core` glyph coverage."""
from fontbakery.utils import bullet_list
from glyphsets.codepoints import CodepointsInSubset
from glyphsets import codepoints
import unicodedata2

required_codepoints = CodepointsInSubset("latin")
gf_glyphsets = codepoints.nam_dir + "/GF Glyph Sets"
codepoints.set_encoding_path(gf_glyphsets)

required_codepoints = codepoints.CodepointsInSubset("GF-latin-core")
diff = required_codepoints - font_codepoints
missing = []
for c in sorted(diff):
Expand Down

0 comments on commit 3af9f83

Please sign in to comment.