Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle filters in generators, closes #824 #839

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

Pangoraw
Copy link
Collaborator

@Pangoraw Pangoraw commented Jan 11, 2021

Hi!

Here is a small fix for issue #824:
The expression in the :filter are reversed so we need to use mapfoldr instead of mapfoldl.

Fixes #824

@Pangoraw Pangoraw force-pushed the comprehension_filter branch from 3c06a44 to 79bdd7a Compare January 12, 2021 08:07
@fonsp
Copy link
Owner

fonsp commented Jan 13, 2021

@fonsp fonsp merged commit 6b6a1fd into fonsp:master Jan 13, 2021
@fonsp
Copy link
Owner

fonsp commented Jan 13, 2021

@Pangoraw Pangoraw deleted the comprehension_filter branch January 14, 2021 08:18
pankgeorg pushed a commit that referenced this pull request Jan 15, 2021
pankgeorg pushed a commit that referenced this pull request Jan 28, 2021
[Diff since v0.12.18](v0.12.18...v0.12.19)

**Closed issues:**
- GPU usage and console messages (#685)
- Feature Proposal: Exported HTML can be passed to a static site generator (#794)
- wait and resume execution on button press (#803)
- Latex code not appropriately displayed (#817)
- Python doesn't work in Pluto (#818)
- add pluto - pluto not found - Julia 1.5.3 macOS (#819)
- Cell output not shown correctly if in-line comment ends with semicolon (#820)
- _llvm (#821)
- Can't move cells (#822)
- Conditions on list comprehensions and execution order (#824)
- Electron app (#825)
- Errors when pressing Ctrl+C to stop Pluto (#827)
- Failed to load notebook error (#829)
- Popup docs don't work for some symbols (#832)
- Running a notebook deleted contents of `.julia/registries` (#834)
- Ctrl+C broken with `julia -e "Pluto.run()"` instead of the REPL (#836)
- Edit or remove default header and footer in exported static PDF (#837)
- Parameters.jl dynamically created macros confuse Pluto (#838)
- Feature request: Open URL from terminal (#840)
- Notebook gets stuck in forever loading state after restarting my PC while running it (#849)
- Syntax highlighting of @. (#854)
- File not found when file newly created while session is running (#855)
- Weird output from a mix of MathJax, Markdown and PlutoUI (#856)
- Misaligned plots when plotting with UnicodePlots.jl using BrailleCanvas (#870)

**Merged pull requests:**
- Pluto ux process file drop (#707) (@pankgeorg)
- Dralbase state managment (#710) (@dralletje)
- PLJ-785 CodeMirror Eject to TextArea - Reload from TextArea in Offline HTML export (#805) (@pankgeorg)
-  Dralbase state managment: Fix front-end tests (#809) (@pankgeorg)
- Update README.md (#814) (@fonsp)
- Regard `:=` in macros as einsum notation (take 2) (#816) (@mcabbott)
- 🧸 Open your own files as samples (#828) (@fonsp)
- Handle filters in generators, closes #824 (#839) (@Pangoraw)
- Update `== nothing` to `=== nothing` in Parse.jl (#841) (@heetbeet)
@fonsp
Copy link
Owner

fonsp commented Jan 30, 2021

@Pangoraw I added tests for:

#288
#826
#776

If you would like some more puzzles!

@Pangoraw
Copy link
Collaborator Author

@Pangoraw I added tests for:

Awesome! I had written the fix for #826 but forgot to send it 🙈 (see #885)

If you would like some more puzzles!

For sure, i will take a look! 🎊

@fonsp
Copy link
Owner

fonsp commented Mar 10, 2021

Hey @Pangoraw!

Did you get my email? I sent it to paul.berg at etu.utc point fr. If that's the wrong address, send an email to [email protected]

@Pangoraw
Copy link
Collaborator Author

I did! Look like my answer got lost 🤔 I sent you another one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditions on list comprehensions and execution order
2 participants