-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle filters in generators, closes #824 #839
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pangoraw
force-pushed
the
comprehension_filter
branch
from
January 12, 2021 08:07
3c06a44
to
79bdd7a
Compare
pankgeorg
pushed a commit
that referenced
this pull request
Jan 15, 2021
pankgeorg
pushed a commit
that referenced
this pull request
Jan 28, 2021
[Diff since v0.12.18](v0.12.18...v0.12.19) **Closed issues:** - GPU usage and console messages (#685) - Feature Proposal: Exported HTML can be passed to a static site generator (#794) - wait and resume execution on button press (#803) - Latex code not appropriately displayed (#817) - Python doesn't work in Pluto (#818) - add pluto - pluto not found - Julia 1.5.3 macOS (#819) - Cell output not shown correctly if in-line comment ends with semicolon (#820) - _llvm (#821) - Can't move cells (#822) - Conditions on list comprehensions and execution order (#824) - Electron app (#825) - Errors when pressing Ctrl+C to stop Pluto (#827) - Failed to load notebook error (#829) - Popup docs don't work for some symbols (#832) - Running a notebook deleted contents of `.julia/registries` (#834) - Ctrl+C broken with `julia -e "Pluto.run()"` instead of the REPL (#836) - Edit or remove default header and footer in exported static PDF (#837) - Parameters.jl dynamically created macros confuse Pluto (#838) - Feature request: Open URL from terminal (#840) - Notebook gets stuck in forever loading state after restarting my PC while running it (#849) - Syntax highlighting of @. (#854) - File not found when file newly created while session is running (#855) - Weird output from a mix of MathJax, Markdown and PlutoUI (#856) - Misaligned plots when plotting with UnicodePlots.jl using BrailleCanvas (#870) **Merged pull requests:** - Pluto ux process file drop (#707) (@pankgeorg) - Dralbase state managment (#710) (@dralletje) - PLJ-785 CodeMirror Eject to TextArea - Reload from TextArea in Offline HTML export (#805) (@pankgeorg) - Dralbase state managment: Fix front-end tests (#809) (@pankgeorg) - Update README.md (#814) (@fonsp) - Regard `:=` in macros as einsum notation (take 2) (#816) (@mcabbott) - 🧸 Open your own files as samples (#828) (@fonsp) - Handle filters in generators, closes #824 (#839) (@Pangoraw) - Update `== nothing` to `=== nothing` in Parse.jl (#841) (@heetbeet)
Hey @Pangoraw! Did you get my email? I sent it to |
I did! Look like my answer got lost 🤔 I sent you another one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Here is a small fix for issue #824:
The expression in the
:filter
are reversed so we need to usemapfoldr
instead ofmapfoldl
.Fixes #824