Display banner from Pluto.__init__, not during precompile #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/mgkuhn/Pluto.jl", rev="banner2")
julia> using Pluto |
fonsp
reviewed
Sep 6, 2023
| @@ -25,6 +25,7 @@ PrecompileTools = "aea7be01-6a6a-4083-8856-8a6e6704d82a" | |||
| REPL = "3fa0cd96-eef1-5676-8a61-b3b8758bbffb" | |||
| RegistryInstances = "2792f1a3-b283-48e8-9a74-f99dce5104f3" | |||
| RelocatableFolders = "05181044-ff0b-4ac5-8273-598c1e38db00" | |||
| Scratch = "6c6a2e73-6563-6170-7368-637461726353" | |||
There was a problem hiding this comment.
compat entry added (needs at least Scratch 1.1 due to the underscore used in the key banner_shown)
Use the Scratch package to record if the banner has already been shown. fixes fonsp#548
fonsp
approved these changes
Sep 12, 2023
|
Retried the frontend tests a bunch of times, it looks like the Pluto server is not launching or is not accepting connections, but the logs are hidden. Working on #2645 to be able to see the logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the printing of the banner into an init function, such that it gets printed at load time, and not any more during pre-compilation (where Pkg currently distractingly presents the banner as a warning).
To preserve the current behaviour that the banner is only shown once after installing the package, use the Scratch package to record if the banner has already been shown.
fixes #548
fixes #2589