Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCLI-207 provide lint command #349

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

STCLI-207 provide lint command #349

wants to merge 4 commits into from

Conversation

zburke
Copy link
Member

@zburke zburke commented May 16, 2024

Provide a lint command. Making eslint a direct dependency here and providing a command to access it allows this package to serve as a conduit through which other packages can access it without having to maintain it as a direct dependency.

Refs STCLI-207

Provide a `lint` command. Making `eslint` a direct dependency here
and providing a command to access it allows this package to serve as a
conduit through which other packages can access it without having to
maintain it as a direct dependency.

Refs STCLI-207
Copy link

github-actions bot commented May 16, 2024

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit a0f23f5. ± Comparison against base commit adafbcf.

♻️ This comment has been updated with latest results.

@zburke zburke marked this pull request as ready for review May 31, 2024 12:39
@zburke zburke requested a review from JohnC-80 May 31, 2024 12:39
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@zburke
Copy link
Member Author

zburke commented Jun 21, 2024

@JohnC-80 , do you think this impl is worthwhile, or should it be a whole lot dumber, e.g. spawn('lint')?

@zburke
Copy link
Member Author

zburke commented Oct 17, 2024

Converting this to draft to take it off the table. The idea is sound but the impl lacks. I think the "right" impl is the "whole lot dumber" one: sth like spawn('lint').

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant