-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESCONF-43 Set ESlint React version setting to detect
#128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for handling this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is obviously correct. Before you merge it, please try it out in a few different repositories to see how it affects things. If there are any changes, announce the pending PR on Slack#stripes-updates before you merge to avoid surprising people with unexpected changes.
Thank you for this fix!
Changing the react version setting is a breaking change, as it alters the linting rules applied. Dependent projects may fail linting checks as a result. |
@alb3rtino , I think this makes sense, but let's run it by @JohnC-80 when he is back next week. See also folio-org/stripes-cli#349. Nobody has been pushing for that, but we could pull in this new version at the same time, allowing us to avoid a breaking change in stripes-cli later. |
https://folio-org.atlassian.net/browse/ESCONF-43
The React version ESlint setting effects the rule behavior of plugins like
eslint-plugin-react
. Having it set to an older React version leads to missing or incorrect linting results. By setting it todetect
, the current React version will be automatically detected, ensuring up-to-date linting.