Test fixes #287
Merged
Test fixes #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 21, 2017
lib/fog/storage/google_json/real.rb
Outdated
| @@ -43,7 +43,7 @@ def signature(params) | |||
| end | |||
| canonical_resource << params[:path].to_s | |||
| canonical_resource << "?" | |||
| for key in (params[:query] || {}).keys | |||
| (params[:query] || {}).keys.each do |key| | |||
There was a problem hiding this comment.
Use each_key instead of keys.each.
icco
approved these changes
Dec 25, 2017
jakob-ml
pushed a commit
to MeisterLabs/fog-google
that referenced
this pull request
Jan 10, 2018
Test fixes
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a bunch of commits to get the tests into a better state - it seems like some are still flaky (running locally) but I wanted to get these initial fixes in.