Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscription push_config does not default to empty hash #214

Closed
durandom opened this issue Apr 24, 2017 · 0 comments · Fixed by #215
Closed

subscription push_config does not default to empty hash #214

durandom opened this issue Apr 24, 2017 · 0 comments · Fixed by #215

Comments

@durandom
Copy link
Contributor

I'm getting

[NoMethodError]: undefined method `empty?' for nil:NilClass
/opt/rh/cfme-gemset/gems/fog-google-0.5.2/lib/fog/google/requests/pubsub/create_subscription.rb:29:in `create_subscription'
/opt/rh/cfme-gemset/gems/fog-google-0.5.2/lib/fog/google/models/pubsub/subscription.rb:71:in `save'
/opt/rh/cfme-gemset/gems/fog-core-1.43.0/lib/fog/core/collection.rb:51:in `create'

The calling code is

google.subscriptions.create(:name  => subscription_name, :topic => topic_name)

My guess is either #168 introduced this regression because this line passes push_config and if it's nil it will pass nil.

Adding push_config => {} to the caller fixes the issue.

durandom added a commit to durandom/manageiq that referenced this issue Apr 24, 2017
@icco icco closed this as completed in #215 Apr 24, 2017
juliancheal pushed a commit to ManageIQ/manageiq-providers-google that referenced this issue May 9, 2017
juliancheal pushed a commit to ManageIQ/manageiq-providers-google that referenced this issue May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant