FlyteRemote - Listing recent #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
==========================================
- Coverage 85.86% 85.85% -0.01%
==========================================
Files 397 397
Lines 31106 31150 +44
Branches 2495 2502 +7
==========================================
+ Hits 26708 26743 +35
- Misses 3723 3732 +9
Partials 675 675
Continue to review full report at Codecov.
|
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
previously approved these changes
Aug 30, 2021
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yee Hing Tong [email protected]
TL;DR
Listing recent executions and tasks from Admin. Holding off on workflows and launch plans - will create a new ticket to track these. The issue is that the Admin endpoints really only support easy listing of IDs for those... listing complete objects for launch plans and workflows ends up with an N+1 style query, which I don't think we should embed in FlyteRemote just yet.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#1290
Follow up flyteorg/flyte#1394