Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] [flytekit] FlyteRemote listing of workflows and launch plans #1394

Open
Tracked by #4064
wild-endeavor opened this issue Aug 30, 2021 · 1 comment
Open
Tracked by #4064
Labels
enhancement New feature or request Epic: Interactive Experience Everything from FlyteRemote to how to better support Jupyter/vscode development with Flyte flytekit FlyteKit Python related issue

Comments

@wild-endeavor
Copy link
Contributor

Motivation: Why do you think this is important?
This issue is a continuation of #1290. That PR only provided for the listing of tasks and executions.

The reason for this is because of the promote_from_model logic for FlyteWorkflow and FlyteLaunchPlan.

For workflows, when promoting from model, we also need the definition of any launch plan nodes.

@classmethod
    def promote_from_model(
        cls,
        base_model: _workflow_models.WorkflowTemplate,
        sub_workflows: Optional[Dict[_identifier.Identifier, _workflow_models.WorkflowTemplate]] = None,
        node_launch_plans: Optional[Dict[_identifier.Identifier, _launch_plan_models.LaunchPlanSpec]] = None,
        tasks: Optional[Dict[_identifier.Identifier, _task_models.TaskTemplate]] = None,
    ) -> "FlyteWorkflow":

For FlyteLaunchPlan, fetching implies
https://github.com/flyteorg/flytekit/blob/b49578b931bf092f7f8ea743abe3ca4a46466f18/flytekit/remote/remote.py#L400-L403
technically also implies the fetching of the underlying workflow for completion's sake.

We can't get all this information today from one Admin call. That means that listing 100 workflows could trigger a whole ton of requests to Admin. This is a separate ticket because we should think about whether there's a better way of doing this.

@wild-endeavor wild-endeavor added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers flytekit FlyteKit Python related issue labels Aug 30, 2021
@wild-endeavor wild-endeavor added Epic: Interactive Experience Everything from FlyteRemote to how to better support Jupyter/vscode development with Flyte and removed untriaged This issues has not yet been looked at by the Maintainers labels Feb 16, 2022
@wild-endeavor wild-endeavor self-assigned this Feb 23, 2022
@eapolinario eapolinario modified the milestones: 1.0.0 - Phoenix!, 1.0.1 Apr 20, 2022
@EngHabu EngHabu modified the milestones: 1.0.1, 1.0.2 May 11, 2022
@eapolinario eapolinario modified the milestones: 1.0.2, 1.1.0 - Hawk Jun 15, 2022
@wild-endeavor wild-endeavor removed their assignment Jun 28, 2022
@wild-endeavor wild-endeavor modified the milestones: 1.1.0 - Hawk, 1.2.0 Jun 28, 2022
@wild-endeavor wild-endeavor modified the milestones: 1.2.0, 1.4.0 Jul 6, 2022
@cosmicBboy cosmicBboy removed this from the 1.4.0 milestone Jan 18, 2023
Copy link

github-actions bot commented Jul 9, 2024

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot removed the stale label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Epic: Interactive Experience Everything from FlyteRemote to how to better support Jupyter/vscode development with Flyte flytekit FlyteKit Python related issue
Projects
None yet
Development

No branches or pull requests

6 participants