Make Flytefile and Flytedirectory's copilot local execution work correctly #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2887 +/- ##
==========================================
- Coverage 84.60% 79.31% -5.29%
==========================================
Files 271 199 -72
Lines 23839 20851 -2988
Branches 2671 2683 +12
==========================================
- Hits 20169 16538 -3631
- Misses 2901 3564 +663
+ Partials 769 749 -20 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 3, 2024
wayner0628
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
|
This PR should pass the CI, please retrigger CI if possible, thank you! |
Signed-off-by: Future-Outlier <[email protected]>
Future-Outlier
previously approved these changes
Nov 14, 2024
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Future-Outlier
previously approved these changes
Nov 14, 2024
Signed-off-by: wayner0628 <[email protected]>
auto-merge was automatically disabled
November 14, 2024 06:00
Head branch was pushed to by a user without write access
Future-Outlier
approved these changes
Nov 14, 2024
Signed-off-by: Future-Outlier <[email protected]>
Future-Outlier
approved these changes
Nov 14, 2024
katrogan
pushed a commit
that referenced
this pull request
Nov 15, 2024
…ectly (#2887) * fix container task local execution path key extraction Signed-off-by: wayner0628 <[email protected]> * lint Signed-off-by: wayner0628 <[email protected]> * lint Signed-off-by: wayner0628 <[email protected]> * lint Signed-off-by: wayner0628 <[email protected]> * ruff format Signed-off-by: wayner0628 <[email protected]> * add wrong syntax unit testing Signed-off-by: wayner0628 <[email protected]> * fix pytest raise Signed-off-by: wayner0628 <[email protected]> * Better Error MSG, very nice PR Wayner Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: wayner0628 <[email protected]> --------- Signed-off-by: wayner0628 <[email protected]> Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: Future-Outlier <[email protected]> Signed-off-by: Katrina Rogan <[email protected]>
400Ping
pushed a commit
to 400Ping/flytekit
that referenced
this pull request
Nov 22, 2024
…ectly (flyteorg#2887) * fix container task local execution path key extraction Signed-off-by: wayner0628 <[email protected]> * lint Signed-off-by: wayner0628 <[email protected]> * lint Signed-off-by: wayner0628 <[email protected]> * lint Signed-off-by: wayner0628 <[email protected]> * ruff format Signed-off-by: wayner0628 <[email protected]> * add wrong syntax unit testing Signed-off-by: wayner0628 <[email protected]> * fix pytest raise Signed-off-by: wayner0628 <[email protected]> * Better Error MSG, very nice PR Wayner Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: wayner0628 <[email protected]> --------- Signed-off-by: wayner0628 <[email protected]> Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: Future-Outlier <[email protected]> Signed-off-by: 400Ping <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#5929
Why are the changes needed?
To make copilot task local execution syntax aligned with remote execution and avoid the not expected behaviors.
What changes were proposed in this pull request?
For flyte directory and flyte file,
make /var/inputs work and make "{{.inputs.inputs}}" doesn't.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
#2258
flyteorg/flyte#5715
Docs link