Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Make Flytefile and Flytedirectory's copilot local execution work correctly #5929

Closed
2 tasks done
Future-Outlier opened this issue Oct 28, 2024 · 1 comment
Closed
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@Future-Outlier
Copy link
Member

Describe the bug

In the unit test below, "{{.inputs.inputs}}", is a wrong syntax, please make /var/inputs work.
(for FlyteFile and FlyteDirectory, we should not use the template's syntax above.
If we use it, the propeller will retrieve the blob type's path, which is not the expected behavior we want.

https://github.com/flyteorg/flytekit/blob/master/tests/flytekit/unit/core/test_local_raw_container.py#L16-L61

Expected behavior

For flyte directory and flyte file,
make /var/inputs work and make "{{.inputs.inputs}}" doesn't.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@Future-Outlier Future-Outlier added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Oct 28, 2024
@wayner0628
Copy link
Contributor

#take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants