[Client][API] get control plane version #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future-Outlier <[email protected]>
Future-Outlier
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla and
thomasjpfan
as code owners
Future-Outlier
changed the title
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Future-Outlier
changed the title
Future-Outlier
changed the title
pingsutw
reviewed
Oct 30, 2024
| @@ -1087,3 +1088,7 @@ def get_download_artifact_signed_url( | |||
| expires_in=expires_in_pb, | |||
| ) | |||
| ) | |||
|
|
|||
| def get_control_plane_version(self) -> str: | |||
There was a problem hiding this comment.
could we add some comments for it
There was a problem hiding this comment.
yes of course thank you!
Signed-off-by: Future-Outlier <[email protected]>
pingsutw
approved these changes
Nov 5, 2024
Future-Outlier
changed the title
Future-Outlier
changed the title
kumare3
pushed a commit
that referenced
this pull request
Nov 8, 2024
* Gate feature by checking backend version Signed-off-by: Future-Outlier <[email protected]> * put context in comments or in serialization settings Signed-off-by: Future-Outlier <[email protected]> * get control plane version and add integration tests Signed-off-by: Future-Outlier <[email protected]> * Update Kevin's advice Signed-off-by: Future-Outlier <[email protected]> --------- Signed-off-by: Future-Outlier <[email protected]>
2 tasks
katrogan
pushed a commit
that referenced
this pull request
Nov 15, 2024
* Gate feature by checking backend version Signed-off-by: Future-Outlier <[email protected]> * put context in comments or in serialization settings Signed-off-by: Future-Outlier <[email protected]> * get control plane version and add integration tests Signed-off-by: Future-Outlier <[email protected]> * Update Kevin's advice Signed-off-by: Future-Outlier <[email protected]> --------- Signed-off-by: Future-Outlier <[email protected]> Signed-off-by: Katrina Rogan <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#5318
Why are the changes needed?
provide version api for users.
What changes were proposed in this pull request?
add a method
get_control_plane_versioninclass SynchronousFlyteClient(_RawSynchronousFlyteClient).How was this patch tested?
local and integration test.
Setup process
Screenshots
Unknown version
Know Version
Check all the applicable boxes
Related PRs
Docs link