Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] pyflyte info show Version #5984

Closed
2 tasks done
Future-Outlier opened this issue Nov 11, 2024 · 2 comments · Fixed by flyteorg/flytekit#2938
Closed
2 tasks done

[Core feature] pyflyte info show Version #5984

Future-Outlier opened this issue Nov 11, 2024 · 2 comments · Fixed by flyteorg/flytekit#2938
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Future-Outlier
Copy link
Member

Motivation: Why do you think this is important?

when typing pyflyte info, we want to know the backend version of flyteadmin, this is super helpful.

(dev) future@outlier ~ % pyflyte info
11:33:17.941096 INFO     file.py:252 - Using flytectl/YAML config /Users/future-outlier/.flyte/config-sandbox.yaml
WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1731295999.145644 10087933 config.cc:230] gRPC experiments enabled: call_status_override_on_cancellation, event_engine_dns, event_engine_listener, http2_stats_fix, monitoring_experiment, pick_first_new, trace_record_callops, work_serializer_clears_time_cache
╭─────────────────────────────────────────────────────────── Flytekit CLI Info ───────────────────────────────────────────────────────────╮
│                                                                                                                                         │
│                                                                                                                                         │
│ This CLI is meant to be used within a virtual environment that has Flytekit installed. Ideally it is used to iterate on your Flyte      │
│ workflows and tasks.                                                                                                                    │
│                                                                                                                                         │
│ Flytekit Version: 1.999.0dev0                                                                                                           │
│ Flyte Backend Endpoint: localhost:30080                                                                                                 │
│                                                                                                                                         │
│                                                                                                                                         │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

Goal: What should the final outcome look like, ideally?

We should add a line Flyte Backend Version: vXXX under Flytekit Version.
You can use API from this PR.
flyteorg/flytekit#2874

Describe alternatives you've considered

This is doable and we should do this.

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@Future-Outlier Future-Outlier added enhancement New feature or request good first issue Good for newcomers labels Nov 11, 2024
@400Ping
Copy link

400Ping commented Nov 11, 2024

#take

@400Ping 400Ping removed their assignment Nov 11, 2024
@davidlin20dev
Copy link
Contributor

#take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants